Commit Graph

1483 Commits

Author SHA1 Message Date
Madhura Bhave
dd43fb5fae Update ProjectGenerationStatPublisherTests to use actual timestamp
Instead of checking that the timestamp was between 2 seconds ago and now,
we can get the actual timestamp from the event and assert on that.

Closes gh-954
2019-07-12 11:58:09 -07:00
Madhura Bhave
218fc20d73 Polish 2019-07-11 15:39:47 -07:00
Andy Wilkinson
45536e51a9 Fix setting file permissions on Windows
See gh-951
2019-07-11 15:58:22 +01:00
Andy Wilkinson
b769c8d6a0 Migrate from Ant to Commons Compress
Closes gh-951
2019-07-11 15:34:33 +01:00
Andy Wilkinson
aad9ce07d7 Broaden usage of Path in place of File
Closes gh-950
2019-07-11 15:34:22 +01:00
Stephane Nicoll
449b22403a Upgrade to spring-javaformat 0.0.15
Closes gh-949
2019-07-10 14:57:35 +02:00
Stephane Nicoll
6af13f6dde Merge pull request #948 from rodrigolgraciano
* pr/948:
  Fix error message when a version could not be parsed

Closes gh-948
2019-07-10 08:45:28 +02:00
Rodrigo Graciano
c5bc699459 Fix error message when a version could not be parsed
See gh-948
2019-07-10 08:44:36 +02:00
Andy Wilkinson
deed4863fb Adopt Spring Java Format's JUnit 5 check
Closes gh-941
2019-07-04 09:57:35 +01:00
Andy Wilkinson
66e871f2c9 Merge pull request #939 from wonwoo
* gh-939:
  Reduce visibility of test class and its methods

Closes gh-939
2019-07-04 09:57:21 +01:00
wonwoo
bcc11c80d5 Reduce visibility of test class and its methods
See gh-939
2019-07-04 09:57:17 +01:00
Madhura Bhave
9df2d29462 Merge pull request #933 from htztomic
* pr/933:
  Ensure executable bit is set on wrapper when baseDir has space

Closes gh-933
2019-07-03 17:18:58 -07:00
HaiTao Zhang
66ea0cb66b Ensure executable bit is set on wrapper when baseDir has space
See gh-933
2019-07-03 17:18:17 -07:00
Madhura Bhave
5a411c67eb Install unzip in CI image 2019-07-02 20:47:00 -07:00
Madhura Bhave
974d36b077 Merge pull request #937 from htztomic
* pr/937:
  Refactor support for testing executable files

Closes gh-937
2019-07-02 14:25:56 -07:00
HaiTao Zhang
292e47e98b Refactor support for testing executable files
Previously, hasExecutableFile only checked if the
file exists and not if it was executable. This commit
ensures that the file exists and is executable using
ExecTask as Unzip and Untar do not preserve file permissions.

See gh-937
2019-07-02 14:25:24 -07:00
Andy Wilkinson
f16971fcd3 Upgrade to spring-javaformat 0.0.14 2019-06-28 11:43:17 +01:00
Andy Wilkinson
d38463c4e7 Fix references to built-in configurations with Gradle Kotlin DSL
Closes gh-917
2019-06-27 20:42:12 +01:00
Andy Wilkinson
db2c867f71 Make compileOnly configuration customization Gradle 4+ specific
Closes gh-848
2019-06-27 20:02:20 +01:00
Andy Wilkinson
8aabfc10d5 Fix initializr-docs' tests
See gh-926
2019-06-27 17:00:10 +01:00
Andy Wilkinson
93975d98b9 Use a strategy for Kotlin version resolution
Closes gh-926
2019-06-27 15:12:45 +01:00
Andy Wilkinson
ab8b1158fa Provide support for resolving versions from Maven boms
This commit introduces a new module, initializer-version-resolver,
that provides support for resolving versions from the dependency
management of a Maven bom. Providing with the bom's coordinates
(groupId, artifactId, and version) a map of groupId:artifactId to
version, derived from the bom's <dependencyManagement>, is returned.

Closes gh-934
2019-06-27 15:12:45 +01:00
Stephane Nicoll
1c7a73c29f Add missing test for JUnit 4 exclusion
See gh-905
2019-06-19 14:50:32 +02:00
Stephane Nicoll
6c79192e75 Polish 2019-06-19 14:47:37 +02:00
Stephane Nicoll
dab8bd644a Upgrade to Spring Boot 2.1.6.RELEASE 2019-06-19 14:01:57 +02:00
Phillip Webb
916ac41253 Update CI credhub references 2019-06-18 13:54:36 -07:00
Madhura Bhave
41e3c2c8bb Merge pull request #924 HaiTao Zhang
* pr/924:
  Polish "Clean artifactId and groupId"
  Clean artifactId and groupId
2019-06-17 16:21:13 -07:00
Madhura Bhave
06286e4fe9 Polish "Clean artifactId and groupId"
Closes gh-924
2019-06-17 16:19:02 -07:00
HaiTao Zhang
10c7a4f32e Clean artifactId and groupId
Maven allows alphanumeric characters and `.`, `_`
and `-` for group id and artifact id. This commit cleans
the artifact id and group id if invalid characters are
found. For artifact id, the invalid characters are replaced
with a hyphen and for group id a dot is used. In cases where
the base directory matches the artifact id, the base directory
is also cleaned.

See gh-924
2019-06-17 16:00:57 -07:00
Stephane Nicoll
918fe40dd9 Polish 2019-06-17 15:37:06 +02:00
Madhura Bhave
4835944cd1 Set core.autocrlf to true for Windows build
See gh-865
2019-06-14 11:14:56 -07:00
Madhura Bhave
60d2365196 Fix location of java home for windows build
See gh-865
2019-06-14 10:31:17 -07:00
Stephane Nicoll
7f20525112 Merge pull request #928 from lndobryden
* pr/928:
  Polish "Fix start.spring.io example configuration link"
  Fix start.spring.io example configuration link

Closes gh-928
2019-06-14 18:08:16 +02:00
Stephane Nicoll
00345e628d Polish "Fix start.spring.io example configuration link"
See gh-928
2019-06-14 18:07:56 +02:00
Lee N Dobryden
b265773f49 Fix start.spring.io example configuration link
See gh-928
2019-06-14 18:07:14 +02:00
Andy Wilkinson
372ff967a1 Make generated .gitignore more multi-module friendly
Closes gh-927
2019-06-14 14:31:22 +01:00
Stephane Nicoll
2f50cf1c8f Format source code
Closes gh-923
2019-06-12 14:46:53 +02:00
Stephane Nicoll
4132306a53 Upgrade to spring-javaformat 0.0.12
See gh-923
2019-06-12 14:46:40 +02:00
Andy Wilkinson
43b1148f64 Merge pull request #921 from OlgaMaciaszek
* gh-921:
  Polish "Allow adding <extensions>true</extensions> to plugin config"
  Allow adding <extensions>true</extensions> to plugin config

Closes gh-921
2019-06-10 14:15:40 +01:00
Andy Wilkinson
50160d4931 Polish "Allow adding <extensions>true</extensions> to plugin config"
See gh-921
2019-06-10 14:13:46 +01:00
Olga Maciaszek-Sharma
3e86a446a8 Allow adding <extensions>true</extensions> to plugin config
See gh-921
2019-06-10 14:13:37 +01:00
Stephane Nicoll
593b9ec878 Properly handle spring boot version metadata failure
See gh-145
2019-06-07 16:40:15 -04:00
Andy Wilkinson
04b2777b32 Correct Kotlin DSL syntax for adding and customizing configurations
Fixes gh-917
2019-06-06 09:51:20 +01:00
Stephane Nicoll
a79a9ae101 Upgrade to Gradle 4.10.3 for Spring Boot 2.0.x projects 2019-06-02 09:21:59 +02:00
Stephane Nicoll
fdd850ba78 Merge pull request #914 from bclozel
* pr/914:
  Prevent caching issues with browsers

Closes gh-914
2019-06-02 09:10:32 +02:00
Brian Clozel
ba73613050 Prevent caching issues with browsers
The main metadata endpoint is available at the root "/" path, for JSON
compatible media types. This endpoint is often requested by CLI and
IDEs. Initializr is setting HTTP response headers to tell clients to
cache the response body.

With this current situation, several HTTP caching issues can happen.

1. Since many formats are available at the same path, proxies can cache
the response body and redistribute it to many clients, even if they
don't request the same media type. To fix that, we need to add a
`Vary: Accept` response header; with that, proxies will cache responses
but take into account that different Accept request headers might yield
different responses.

2. Browsers have very specific caching implementations, and exposing
that metadata endpoint on "/" and at the same time an HTML page will
create issues related to HTTP caching. Navigation and refreshes might
result with strange problems. To fix that, we need to reinstate the
`/metadata/client` endpoint as a first class citizen (and not just a
redirect). This way, Web UIs can freely use that path to request the
metadata, without risking caching issues.

See gh-914
2019-06-02 09:08:12 +02:00
Stephane Nicoll
ce150380c2 Polish method name 2019-05-31 12:13:59 +02:00
Stephane Nicoll
209f092168 Make hasText public to validate corner cases 2019-05-31 11:19:37 +02:00
Stephane Nicoll
e063405b92 Allow to initialize a dependency builder from an existing dependency 2019-05-31 11:19:37 +02:00
Stephane Nicoll
31b60a6955 Model custom configuration for a Gradle dependency
Closes gh-850
2019-05-31 11:19:30 +02:00