* Fixing that RecipeManagerTests failed due to HttpContext not being available
* Fixing OwnerEditor tests in CommonPartProviderTests as the owner editor now checks for a different permission since 5b0c82d1ad
* Fixing typo in CommonPartProviderTests.UpdateModelStub class name
* Fixing that test cases for invalid path in FileSystemStorageProviderTests broke in a3e9bef3ca (issue #6802, PR #6919)
I should review PRs more carefully!
* Fixing CurrentCultureWorkContextTests
* Fixing indentation in DefaultDateFormatterTests
* Updating Orchard.Azure.Web's required version of System.Web.Mvc to match the rest of the solution
* Orchard.Specs: Fixing assembly loading errors when starting up the web host by adding binding redirects
* Adding empty compile workflow from dev
* Adding the compile workflow's actual contents
* Changing default shell to pwsh (msbuild was not found in cmd?)
* Adding msbuild to PATH
* Removing unused references to System.Net.Http
* Replacing System.Net.Http references with its NuGet package to pin the correct version number (experimental)
* Upgrading Microsoft.CodeDom.Providers.DotNetCompilerPlatform to 4.1.0 (latest) to get rid of old System.Http.Net dependency
* Orchard.proj: Spec target actually depends on only the Compile target, not Package-Stage (experimental)
* Compile workflow: Testing the Test and Spec targets
* Fixing Test step
* Fixing compile workflow to also mark Razor compilation warnings as errors
* Restoring Orchard.Specs/Hosting/Orchard.Web/Web.config to match Orchard.Web's web.config closer
so that it loads assemblies from the Dependencies folder.
This fixes the error with Autofac not being able to resolve dependencies for DefaultOrchardShell
* Orchard.Specs/Hosting/Orchard.Web/Global.asax.cs: Workaround for AntiForgeryToken bug in ASP.NET MVC since version 5.2.4
https://github.com/aspnet/AspNetWebStack/issues/162
* Revert "Replacing System.Net.Http references with its NuGet package to pin the correct version number (experimental)"
This reverts commit 087f2849b1.
* Revert "Upgrading Microsoft.CodeDom.Providers.DotNetCompilerPlatform to 4.1.0 (latest) to get rid of old System.Http.Net dependency"
This reverts commit be2ba866e3.
* Reverting the addition of assembly binding redirects to Orchard.Specs/Hosting/Simple.Web/Web.config
since it doesn't need them like Orchard.Specs/Hosting/Orchard.Web/Web.config does
* Disabling Test and Spec execution for now
* Orchard.Framework: Making the System.Net.Http not-private to prevent an outdated version sticking around
* Orchard.Workflows: Adding assembly binding redirect for System.Net.Http to avoid Razor compilation warning
* Moving the System.Net.Http assembly redirect to Orchard.Web
* Specs: Fixing "I can create browse blog posts on several pages" Blog test's usage of "I should not see" and correcting the parameters too
because unlike "I should see", this is not a regex match, just contains
* Specs: Fixing "I can create browse blog posts on several pages" Blog test's flakyness due to timing
because the blog posts are created quickly after one another and the lack of millisecond-precision can cause
the blog posts to appear out of order of creation
* Specs: Media test simplified since the Orchard.Media feature is deprecated
* Adding step to the Compile workflow to upload the MSBuild binlog results
* Pinning the referenced version of System.Net.Http to 4.2.0.0 to prevent Razor compilation warning
System.Net.Http is known to have such problems across different framework versions ways of referencing it
The original warning is:
ASPNETCOMPILER : error : The following assembly has dependencies on a version of the .NET Framework that is higher than the target and might not load correctly during runtime causing a failure: Orchard.Workflows, Version=1.10.3.0, Culture=neutral, PublicKeyToken=null. The dependencies are: System.Net.Http, Version=4.2.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a. You should either ensure that the dependent assembly is correct for the target framework, or ensure that the target framework you are addressing is that of the dependent assembly. [D:\a\Orchard\Orchard\src\Orchard.Web\Modules\Orchard.Workflows\Orchard.Workflows.csproj
* Re-enabling the Test step
* Re-enabling the Specs step
* Marking System.Net.Http references as private (copy local) to make sure that it's always available, because it requires a specific version
* Revert "Marking System.Net.Http references as private (copy local) to make sure that it's always available, because it requires a specific version"
This reverts commit e4f5632236.
* Orchard.Specs: Adding Settings feature
* Orchard.Specs: Updating DateTime.CreatingAndUsingDateTimeFieldsInAnotherCulture structure without functional change
* Orchard.Specs: Updating Settings.AddingANewSiteCultureAndSelectingItAsTheDefaultWorks to correctly detect that a culture that wasn't added before can be set as default
* Fixing outdated assembly binding redirects
* Fixing Newtonsoft.Json references
* Updating Newtonsoft.Json reference in Orchard.Messaging.Tests.csproj
* Disabling the Test step for now
* Adding System.Net.Http 4.2.0.0 reference to Orchard.Email's web.config to fix Razor compilation warning
* Re-enabling the Test step
* Fixing HqlExpressionTests.AllDataTypesCanBeQueried
* Fixing initialization error error in StylesheetBindingStrategyTests
* Fixing initialization errors in FeatureManagerTests
* Fixing Orchard.Tests.Localization.TextTests
* Code styling and fixing warning in Orchard.Tests/UI/Resources/ResourceManagerTests.cs
* Updating Orchard.Tests/UI/Resources/ResourceManagerTests.cs according to ResourceManager API change in ac11024be4
and removing obsolete tests
* Orchard.Tests.Modules: Adding missing reference to Iesi.Collections (that doesn't cause a build error, just when running tests)
* Fixing initialization errors in ModuleStepTest and ThemeStepTest
* Fixing initialization errors in ShellDescriptorManagerTests
* Fixing initialization errors in AccountControllerTests
* Fixing that MembershipServiceTests should use IPasswordService, also making SaltAndPasswordShouldBeDifferentEvenWithSameSourcePassword test parameters more readable
* Specs: Updating the Newtonsoft.Json binding redirect in the spec app's web.config
* Re-enabling the Spec step
* Upgrading actions to latest versions
These actions generated the Node.js 16 deprecation warning
* Removing SpecFlow test execution from the compile workflow
* Testing the branch strategy matrix concept to be used for the nightly build
* Revert "Testing the branch strategy matrix concept to be used for the nightly build"
This reverts commit 1354e367b7.
* Adding workflow to run specflow tests as a nightly build
* Updating Orchard.Tests.ContentManagement.HqlExpressionTests.ShouldSortRandomly to decrease failure chance due to randomness
* Added checks to GetImageProfileUrl function to avoid trying to resize files with no ImagePart. If no content item is passed as a parameter, file gets to be processed anyway (throwing and logging exception is the file isn't processable - e.g. is a svg file)
* Added reference to Orchard.MediaLibrary.
* added MaxLength setting for TextField
# Conflicts:
# src/Orchard.Web/Modules/Orchard.Taxonomies/Settings/TaxonomyFieldEditorEvents.cs
* added MaxLength setting for TitlePart
* added missing files
* Removed where clause
* changed title length to a constant and updated the recipe
* added comment to remind people to update the migration when they change the constant introduced previously
* fixed hint text for title
* fixed maxLength initialization in TitlePartSettings.cshtml
* MaxTitleLength constant is now Pascal case
* Correction on constant spelling in TitlePartSettings shape.
---------
Co-authored-by: Andrea Piovanelli <andrea.piovanelli@laser-group.com>
* Updated XML helper to support storing and parsing of Guid
* Adding Guid and Guid? assertions to XmlHelperTests
* Restoring XmlHelper
* Adding Guid and Guid? assertions to XmlHelperTests
---------
Co-authored-by: Benedek Farkas <benedek.farkas@lombiq.com>
* Display CustomForm_Wrapper shape only if shape type is Detail.
Publish button has to be visible only if content is draftable AND is set to show the publish button
# Conflicts:
# src/Orchard.Web/Modules/Orchard.CustomForms/Drivers/CustomFormPartDriver.cs
# src/Orchard.Web/Modules/Orchard.CustomForms/Views/Item/Create.cshtml
# src/Orchard.Web/Modules/Orchard.CustomForms/Views/Parts.CustomForm.Wrapper.cshtml
* Added EditorBuilderWrapper.
* Prevent TermsFilter from having to deal with empty strings:
filter them out before parsing them to int
in form, convert taxonomies to OptionGroups rather than options with no value
* Update src/Orchard.Web/Modules/Orchard.Taxonomies/Projections/TermsFilter.cs
Co-authored-by: Sébastien Ros <sebastienros@gmail.com>
---------
Co-authored-by: Sébastien Ros <sebastienros@gmail.com>
* Using MailKit instead of SmtpClient
* Removing 2 more references to System.Net.Http that we hopefully don't need at all anymore
* Attempting to fix Razor compilation warning about Orchard.Email's reference to System.Net.Http
* Improving SmtpSettings.cshtml a bit (port number restrictions, user name box width)
* Fixing encription method is not persisted
* Adding migration step to migrate from EnableSsl to EncryptionMethod in SmtpSettingsPart
* Code styling/simplifications
* Using infoset default values instead of Migrations to keep SSL settings when upgrading to MailKit
---------
Co-authored-by: Lombiq <github@lombiq.com>
Co-authored-by: Benedek Farkas <benedek.farkas@lombiq.com>
* Added flag to display model error by LocalizationExtensionHandler if media have been removed from the field only. This ensures that no duplicate model error has displayed.
* Restored formatting for else branches
---------
Co-authored-by: Matteo Piovanelli <MatteoPiovanelli-Laser@users.noreply.github.com>
* Fixing that RecipeManagerTests failed due to HttpContext not being available
* Fixing OwnerEditor tests in CommonPartProviderTests as the owner editor now checks for a different permission since 5b0c82d1ad
* Fixing typo in CommonPartProviderTests.UpdateModelStub class name
* Fixing that test cases for invalid path in FileSystemStorageProviderTests broke in a3e9bef3ca (issue #6802, PR #6919)
I should review PRs more carefully!
* Fixing CurrentCultureWorkContextTests
* Fixing indentation in DefaultDateFormatterTests
* Updating Orchard.Azure.Web's required version of System.Web.Mvc to match the rest of the solution
* Orchard.Specs: Fixing assembly loading errors when starting up the web host by adding binding redirects
* Adding empty compile workflow from dev
* Adding the compile workflow's actual contents
* Changing default shell to pwsh (msbuild was not found in cmd?)
* Adding msbuild to PATH
* Removing unused references to System.Net.Http
* Replacing System.Net.Http references with its NuGet package to pin the correct version number (experimental)
* Upgrading Microsoft.CodeDom.Providers.DotNetCompilerPlatform to 4.1.0 (latest) to get rid of old System.Http.Net dependency
* Orchard.proj: Spec target actually depends on only the Compile target, not Package-Stage (experimental)
* Compile workflow: Testing the Test and Spec targets
* Fixing Test step
* Fixing compile workflow to also mark Razor compilation warnings as errors
* Restoring Orchard.Specs/Hosting/Orchard.Web/Web.config to match Orchard.Web's web.config closer
so that it loads assemblies from the Dependencies folder.
This fixes the error with Autofac not being able to resolve dependencies for DefaultOrchardShell
* Orchard.Specs/Hosting/Orchard.Web/Global.asax.cs: Workaround for AntiForgeryToken bug in ASP.NET MVC since version 5.2.4
https://github.com/aspnet/AspNetWebStack/issues/162
* Revert "Replacing System.Net.Http references with its NuGet package to pin the correct version number (experimental)"
This reverts commit 087f2849b1.
* Revert "Upgrading Microsoft.CodeDom.Providers.DotNetCompilerPlatform to 4.1.0 (latest) to get rid of old System.Http.Net dependency"
This reverts commit be2ba866e3.
* Reverting the addition of assembly binding redirects to Orchard.Specs/Hosting/Simple.Web/Web.config
since it doesn't need them like Orchard.Specs/Hosting/Orchard.Web/Web.config does
* Disabling Test and Spec execution for now
* Orchard.Framework: Making the System.Net.Http not-private to prevent an outdated version sticking around
* Orchard.Workflows: Adding assembly binding redirect for System.Net.Http to avoid Razor compilation warning
* Moving the System.Net.Http assembly redirect to Orchard.Web
* Specs: Fixing "I can create browse blog posts on several pages" Blog test's usage of "I should not see" and correcting the parameters too
because unlike "I should see", this is not a regex match, just contains
* Specs: Fixing "I can create browse blog posts on several pages" Blog test's flakyness due to timing
because the blog posts are created quickly after one another and the lack of millisecond-precision can cause
the blog posts to appear out of order of creation
* Specs: Media test simplified since the Orchard.Media feature is deprecated
* Adding step to the Compile workflow to upload the MSBuild binlog results
* Pinning the referenced version of System.Net.Http to 4.2.0.0 to prevent Razor compilation warning
System.Net.Http is known to have such problems across different framework versions ways of referencing it
The original warning is:
ASPNETCOMPILER : error : The following assembly has dependencies on a version of the .NET Framework that is higher than the target and might not load correctly during runtime causing a failure: Orchard.Workflows, Version=1.10.3.0, Culture=neutral, PublicKeyToken=null. The dependencies are: System.Net.Http, Version=4.2.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a. You should either ensure that the dependent assembly is correct for the target framework, or ensure that the target framework you are addressing is that of the dependent assembly. [D:\a\Orchard\Orchard\src\Orchard.Web\Modules\Orchard.Workflows\Orchard.Workflows.csproj
* Re-enabling the Test step
* Re-enabling the Specs step
* Marking System.Net.Http references as private (copy local) to make sure that it's always available, because it requires a specific version
* Revert "Marking System.Net.Http references as private (copy local) to make sure that it's always available, because it requires a specific version"
This reverts commit e4f5632236.
* Orchard.Specs: Adding Settings feature
* Orchard.Specs: Updating DateTime.CreatingAndUsingDateTimeFieldsInAnotherCulture structure without functional change
* Orchard.Specs: Updating Settings.AddingANewSiteCultureAndSelectingItAsTheDefaultWorks to correctly detect that a culture that wasn't added before can be set as default
* Fixing Newtonsoft.Json references
* Specs: Workaround for the DefineDefaultCulture binding and removing the Settings feature which is now redundant with CreatingAndUsingDateTimeFieldsInAnotherCulture
* Updating the compile workflow to run the build + tests on PR, dev and 1.10.x commits
* Adding the compile workflow to the solution
* Checked back previously selected terms after replacing the TaxonomyField markup.
* Checkbox reset before checking back selected items.
* Javascript functions to refresh localized terms are now named to be unique. For this purpose, added PartName property to LocalizedTaxonomiesViewModel.
* Code refactoring: added variables for part-field differentiator and function name.
