lsm/konva
1
0
Fork 0
mirror of https://github.com/konvajs/konva.git synced 2025-04-05 20:48:28 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Minor improvement to the implementation of Text._sceneFunc

Browse Source 
As the context's translate() is additive, there is no need for
the two consecutive calls of it inside _sceneFunc(): The same
effect can be achieved with with just one call of translate().

A corresponding update was done in the unit test for Text that
had a pair of calls to translate() in the expected call dump.
This commit is contained in:
VladimirTechMan 2019-01-19 14:52:43 +03:00
parent 9baf66113e
commit e6276d28db
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/shapes/Text.ts
View File

@ -159,8 +159,7 @@ export class Text extends Shape {
}
if (padding) {
context.translate(padding, 0);
context.translate(0, alignY + padding + lineHeightPx / 2);
context.translate(padding, alignY + padding + lineHeightPx / 2);
} else {
context.translate(0, alignY + lineHeightPx / 2);
}

2
test/unit/shapes/Text-test.js
View File

@ -653,7 +653,7 @@ suite('Text', function() {
stage.add(layer);
var trace =
'clearRect(0,0,578,200);save();transform(1,0,0,1,10,10);beginPath();rect(0,0,200,100);closePath();lineWidth=2;strokeStyle=black;stroke();restore();save();transform(1,0,0,1,10,10);font=normal normal 16px Arial;textBaseline=middle;textAlign=left;translate(10,0);translate(0,50);save();translate(17.523,0);fillStyle=#555;fillText(Some awesome text,0,0);restore();restore();';
'clearRect(0,0,578,200);save();transform(1,0,0,1,10,10);beginPath();rect(0,0,200,100);closePath();lineWidth=2;strokeStyle=black;stroke();restore();save();transform(1,0,0,1,10,10);font=normal normal 16px Arial;textBaseline=middle;textAlign=left;translate(10,50);save();translate(17.523,0);fillStyle=#555;fillText(Some awesome text,0,0);restore();restore();';
assert.equal(layer.getContext().getTrace(), trace);
});