fix memory leak. close #198

CHANGELOG.md

@@ -21,6 +21,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 - Fixed "calling remove() for dragging shape will throw an error"
 - Fixed wrong opacity level for cached group with opacity
 - More consistent shadows on HDPI screens
+- Fixed memory leak for nodes with several names
 
 ## [1.2.2][2016-09-15]
 

konva.js

@@ -3,7 +3,7 @@
  * Konva JavaScript Framework v1.2.2
  * http://konvajs.github.io/
  * Licensed under the MIT or GPL Version 2 licenses.
- * Date: Wed Dec 14 2016
+ * Date: Tue Jan 10 2017
  *
  * Original work Copyright (C) 2011 - 2013 by Eric Rowell (KineticJS)
  * Modified work Copyright (C) 2014 - 2015 by Anton Lavrenov (Konva)
@@ -2899,7 +2899,13 @@
         destroy: function() {
             // remove from ids and names hashes
             Konva._removeId(this.getId());
-            Konva._removeName(this.getName(), this._id);
+
+            // remove all names
+            var names = (this.getName() || '').split(/\s/g);
+            for(var i = 0; i < names.length; i++) {
+                var subname = names[i];
+                Konva._removeName(subname, this._id);
+            }
 
             this.remove();
             return this;

src/Node.js

@@ -606,7 +606,13 @@
         destroy: function() {
             // remove from ids and names hashes
             Konva._removeId(this.getId());
-            Konva._removeName(this.getName(), this._id);
+
+            // remove all names
+            var names = (this.getName() || '').split(/\s/g);
+            for(var i = 0; i < names.length; i++) {
+                var subname = names[i];
+                Konva._removeName(subname, this._id);
+            }
 
             this.remove();
             return this;

test/unit/Node-test.js

@@ -2557,6 +2557,32 @@ suite('Node', function() {
         assert.equal(circle.getParent(), undefined);
     });
 
+    // ======================================================
+    test('memory leak test for destroy and a shape with several names', function() {
+        var stage = addStage();
+        var layer = new Konva.Layer();
+        var circle = new Konva.Circle({
+            x: stage.getWidth() / 2,
+            y: stage.getHeight() / 2,
+            radius: 70,
+            fill: 'green',
+            stroke: 'black',
+            strokeWidth: 4,
+            name: 'my-new-shape my-new-circle'
+        });
+
+        layer.add(circle);
+        stage.add(layer);
+
+        assert.equal(Konva.names['my-new-shape'].length, 1);
+        assert.equal(Konva.names['my-new-circle'].length, 1);
+
+        circle.destroy();
+
+        assert.equal(Konva.names['my-new-shape'], undefined);
+        assert.equal(Konva.names['my-new-circle'], undefined);
+    });
+
     // ======================================================
     test('destroy shape without adding its parent to stage', function() {
         var stage = addStage();