lsm/konva
1
0
Fork 0
mirror of https://github.com/konvajs/konva.git synced 2025-04-30 00:29:50 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fixed gub with Container.remove() method which had bad logic removing children nodes

Browse Source
This commit is contained in:
Eric Rowell 2012-07-04 22:04:03 -07:00
parent 26e753b90c
commit d28d2c910d
3 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
dist/kinetic-core.js vendored
View File

@ -1486,10 +1486,8 @@ Kinetic.Container = Kinetic.Node.extend({
this._setChildrenIndices();
// remove children
if(child.children) {
for(var n = 0; n < child.children.length; n++) {
child.remove(child.children[n]);
}
while(child.children && child.children.length > 0) {
child.remove(child.children[0]);
}
// do extra stuff if needed

4
dist/kinetic-core.min.js vendored
View File

File diff suppressed because one or more lines are too long

6
src/Container.js
View File

@ -85,10 +85,8 @@ Kinetic.Container = Kinetic.Node.extend({
this._setChildrenIndices();
// remove children
if(child.children) {
for(var n = 0; n < child.children.length; n++) {
child.remove(child.children[n]);
}
while(child.children && child.children.length > 0) {
child.remove(child.children[0]);
}
// do extra stuff if needed