lsm/konva
1
0
Fork 0
mirror of https://github.com/konvajs/konva.git synced 2025-04-05 20:48:28 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #668 from wuhaochen/patch-dangling-stage

Browse Source 
Fixed set container for dangling stage, related to #510
This commit is contained in:
Anton Lavrenov 2019-06-12 12:30:33 -05:00 committed by GitHub
commit bbaa40a686
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Stage.ts
View File

@ -190,7 +190,9 @@ export class Stage extends Container<BaseLayer> {
}
this._setAttr(CONTAINER, container);
if (this.content) {
this.content.parentElement.removeChild(this.content);
if (this.content.parentElement) {
this.content.parentElement.removeChild(this.content);
}
container.appendChild(this.content);
}
return this;

12
test/unit/Stage-test.js
View File

@ -203,6 +203,18 @@ suite('Stage', function() {
assert.equal(clone.content, container.children[0]);
});
test('dangling stage ', function() {
var stage = addStage();
var container = stage.container();
var parent = stage.content.parentElement;
parent.removeChild(stage.content);
stage.setContainer(container);
assert.equal(stage.container(), container);
});
// ======================================================
test('stage getIntersection()', function() {
var stage = addStage();