lsm/konva
1
0
Fork 0
mirror of https://github.com/konvajs/konva.git synced 2025-04-05 18:24:17 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix image size detection on zero values. fix #774

Browse Source
This commit is contained in:
Anton Lavrenov 2019-12-24 11:20:44 -05:00
parent 42a5876d11
commit 76c0e3f272
4 changed files with 74 additions and 1334 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CHANGELOG.md
View File

@ -5,6 +5,8 @@ This project adheres to [Semantic Versioning](http://semver.org/).
## Not released:
* Add ability to use `width = 0` and `height = 0` for `Konva.Image`.
## 4.1.0 - 2019-12-23
* Make events work on some CSS transforms

1383
konva.js
View File

File diff suppressed because it is too large Load Diff

4
src/shapes/Image.ts
View File

@ -92,11 +92,11 @@ export class Image extends Shape<ImageConfig> {
}
getWidth() {
var image = this.image();
return this.attrs.width || (image ? image.width : 0);
return this.attrs.width ?? (image ? image.width : 0);
}
getHeight() {
var image = this.image();
return this.attrs.height || (image ? image.height : 0);
return this.attrs.height ?? (image ? image.height : 0);
}
/**

19
test/unit/shapes/Image-test.js
View File

@ -368,4 +368,23 @@ suite('Image', function() {
done();
});
});
test.only('check zero values', function(done) {
var stage = addStage();
var layer = new Konva.Layer();
stage.add(layer);
var src = 'assets/darth-vader.jpg';
Konva.Image.fromURL(src, function(image) {
layer.add(image);
layer.draw();
image.width(0);
image.height(0);
layer.draw();
assert.equal(image.width(), 0);
assert.equal(image.height(), 0);
done();
});
});
});