From cc28960daa6eb2706ad4b29776a6f3a8057f858e Mon Sep 17 00:00:00 2001
From: Evan Patterson <ejpatters@gmail.com>
Date: Wed, 11 Sep 2019 10:53:45 -0700
Subject: [PATCH 1/3] Fix typings in signatures of findAncestor(s)

In TypeScript, optional arguments must be declared as such.
---
 src/Node.ts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/Node.ts b/src/Node.ts
index cb6ff399..868d3e8e 100644
--- a/src/Node.ts
+++ b/src/Node.ts
@@ -1497,7 +1497,7 @@ export abstract class Node<Config extends NodeConfig = NodeConfig> {
    * // get one of the parent group
    * var parentGroups = node.findAncestors('Group');
    */
-  findAncestors(selector, includeSelf, stopNode) {
+  findAncestors(selector?, includeSelf?, stopNode?) {
     var res: Array<Node> = [];
 
     if (includeSelf && this._isMatch(selector)) {
@@ -1530,7 +1530,7 @@ export abstract class Node<Config extends NodeConfig = NodeConfig> {
    * // get one of the parent group
    * var group = node.findAncestors('.mygroup');
    */
-  findAncestor(selector, includeSelf, stopNode) {
+  findAncestor(selector?, includeSelf?, stopNode?) {
     return this.findAncestors(selector, includeSelf, stopNode)[0];
   }
   // is current node match passed selector?

From 28700e1904f98f678114d466a47b0a18ff38e552 Mon Sep 17 00:00:00 2001
From: Evan Patterson <ejpatters@gmail.com>
Date: Thu, 12 Sep 2019 16:13:37 -0700
Subject: [PATCH 2/3] Selector parameter in findAncestor(s) is not optional

---
 src/Node.ts | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/Node.ts b/src/Node.ts
index 868d3e8e..5303e432 100644
--- a/src/Node.ts
+++ b/src/Node.ts
@@ -1489,7 +1489,7 @@ export abstract class Node<Config extends NodeConfig = NodeConfig> {
    * get all ancestors (parent then parent of the parent, etc) of the node
    * @method
    * @name Konva.Node#findAncestors
-   * @param {String} [selector] selector for search
+   * @param {String} selector selector for search
    * @param {Boolean} [includeSelf] show we think that node is ancestro itself?
    * @param {Konva.Node} [stopNode] optional node where we need to stop searching (one of ancestors)
    * @returns {Array} [ancestors]
@@ -1497,7 +1497,7 @@ export abstract class Node<Config extends NodeConfig = NodeConfig> {
    * // get one of the parent group
    * var parentGroups = node.findAncestors('Group');
    */
-  findAncestors(selector?, includeSelf?, stopNode?) {
+  findAncestors(selector, includeSelf?, stopNode?) {
     var res: Array<Node> = [];
 
     if (includeSelf && this._isMatch(selector)) {
@@ -1522,7 +1522,7 @@ export abstract class Node<Config extends NodeConfig = NodeConfig> {
    * get ancestor (parent or parent of the parent, etc) of the node that match passed selector
    * @method
    * @name Konva.Node#findAncestor
-   * @param {String} [selector] selector for search
+   * @param {String} selector selector for search
    * @param {Boolean} [includeSelf] show we think that node is ancestro itself?
    * @param {Konva.Node} [stopNode] optional node where we need to stop searching (one of ancestors)
    * @returns {Konva.Node} ancestor
@@ -1530,7 +1530,7 @@ export abstract class Node<Config extends NodeConfig = NodeConfig> {
    * // get one of the parent group
    * var group = node.findAncestors('.mygroup');
    */
-  findAncestor(selector?, includeSelf?, stopNode?) {
+  findAncestor(selector, includeSelf?, stopNode?) {
     return this.findAncestors(selector, includeSelf, stopNode)[0];
   }
   // is current node match passed selector?

From 97dc4b6143f42b679577da74bbde8b91646b00a1 Mon Sep 17 00:00:00 2001
From: naqtn <your.email@example.com>
Date: Tue, 17 Sep 2019 19:58:32 +0900
Subject: [PATCH 3/3] Fix doc of `Node.getAbsoluteScale()` return type

---
 src/Node.ts | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/Node.ts b/src/Node.ts
index 5303e432..8e1ecba9 100644
--- a/src/Node.ts
+++ b/src/Node.ts
@@ -1681,7 +1681,10 @@ export abstract class Node<Config extends NodeConfig = NodeConfig> {
    *  account its ancestor scales
    * @method
    * @name Konva.Node#getAbsoluteScale
-   * @returns {Konva.Transform}
+   * @returns {Object}
+   * @example
+   * // get absolute scale x
+   * var scaleX = node.getAbsoluteScale().x;
    */
   getAbsoluteScale(top?) {
     // if using an argument, we can't cache the result.