From 4334b2a08728b11fd1d5205e7303d60b348d8eeb Mon Sep 17 00:00:00 2001 From: lavrton Date: Tue, 10 Mar 2015 19:16:13 +0700 Subject: [PATCH] fix `to` onFinish callback flow --- CHANGELOG.md | 6 ++++++ src/Tween.js | 2 +- test/unit/Tween-test.js | 14 +++++++++++++- 3 files changed, 20 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 291beeb1..9b2be9ca 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,12 @@ All notable changes to this project will be documented in this file. This project adheres to [Semantic Versioning](http://semver.org/). +## [Not released][Not released] + +### Fixed +- `to` don't throw error if no `onFinish` callback + + ## [0.9.0][2015-02-27] ### Fixed diff --git a/src/Tween.js b/src/Tween.js index 84d4d8be..bb49943d 100644 --- a/src/Tween.js +++ b/src/Tween.js @@ -290,7 +290,7 @@ params.node = this; params.onFinish = function() { tween.destroy(); - onFinish(); + onFinish && onFinish(); }; var tween = new Konva.Tween(params); tween.play(); diff --git a/test/unit/Tween-test.js b/test/unit/Tween-test.js index a9af3753..a177b69e 100644 --- a/test/unit/Tween-test.js +++ b/test/unit/Tween-test.js @@ -170,7 +170,7 @@ suite('Tween', function() { tween.play(); }); - test('transitionTo method', function(done) { + test('to method', function(done) { var stage = addStage(); var layer = new Konva.Layer(); @@ -197,5 +197,17 @@ suite('Tween', function() { }); }); + test('to method simple usage', function(done) { + var stage = addStage(); + + stage.to({ + x : 10, + duration : 0.001 + }); + setTimeout(function() { + done(); + }, 50); + }); + });