* Added flag to display model error by LocalizationExtensionHandler if media have been removed from the field only. This ensures that no duplicate model error has displayed.
* Restored formatting for else branches
---------
Co-authored-by: Matteo Piovanelli <MatteoPiovanelli-Laser@users.noreply.github.com>
* Fixing that RecipeManagerTests failed due to HttpContext not being available
* Fixing OwnerEditor tests in CommonPartProviderTests as the owner editor now checks for a different permission since 5b0c82d1ad
* Fixing typo in CommonPartProviderTests.UpdateModelStub class name
* Fixing that test cases for invalid path in FileSystemStorageProviderTests broke in a3e9bef3ca (issue #6802, PR #6919)
I should review PRs more carefully!
* Fixing CurrentCultureWorkContextTests
* Fixing indentation in DefaultDateFormatterTests
* Updating Orchard.Azure.Web's required version of System.Web.Mvc to match the rest of the solution
* Orchard.Specs: Fixing assembly loading errors when starting up the web host by adding binding redirects
* Adding empty compile workflow from dev
* Adding the compile workflow's actual contents
* Changing default shell to pwsh (msbuild was not found in cmd?)
* Adding msbuild to PATH
* Removing unused references to System.Net.Http
* Replacing System.Net.Http references with its NuGet package to pin the correct version number (experimental)
* Upgrading Microsoft.CodeDom.Providers.DotNetCompilerPlatform to 4.1.0 (latest) to get rid of old System.Http.Net dependency
* Orchard.proj: Spec target actually depends on only the Compile target, not Package-Stage (experimental)
* Compile workflow: Testing the Test and Spec targets
* Fixing Test step
* Fixing compile workflow to also mark Razor compilation warnings as errors
* Restoring Orchard.Specs/Hosting/Orchard.Web/Web.config to match Orchard.Web's web.config closer
so that it loads assemblies from the Dependencies folder.
This fixes the error with Autofac not being able to resolve dependencies for DefaultOrchardShell
* Orchard.Specs/Hosting/Orchard.Web/Global.asax.cs: Workaround for AntiForgeryToken bug in ASP.NET MVC since version 5.2.4
https://github.com/aspnet/AspNetWebStack/issues/162
* Revert "Replacing System.Net.Http references with its NuGet package to pin the correct version number (experimental)"
This reverts commit 087f2849b1.
* Revert "Upgrading Microsoft.CodeDom.Providers.DotNetCompilerPlatform to 4.1.0 (latest) to get rid of old System.Http.Net dependency"
This reverts commit be2ba866e3.
* Reverting the addition of assembly binding redirects to Orchard.Specs/Hosting/Simple.Web/Web.config
since it doesn't need them like Orchard.Specs/Hosting/Orchard.Web/Web.config does
* Disabling Test and Spec execution for now
* Orchard.Framework: Making the System.Net.Http not-private to prevent an outdated version sticking around
* Orchard.Workflows: Adding assembly binding redirect for System.Net.Http to avoid Razor compilation warning
* Moving the System.Net.Http assembly redirect to Orchard.Web
* Specs: Fixing "I can create browse blog posts on several pages" Blog test's usage of "I should not see" and correcting the parameters too
because unlike "I should see", this is not a regex match, just contains
* Specs: Fixing "I can create browse blog posts on several pages" Blog test's flakyness due to timing
because the blog posts are created quickly after one another and the lack of millisecond-precision can cause
the blog posts to appear out of order of creation
* Specs: Media test simplified since the Orchard.Media feature is deprecated
* Adding step to the Compile workflow to upload the MSBuild binlog results
* Pinning the referenced version of System.Net.Http to 4.2.0.0 to prevent Razor compilation warning
System.Net.Http is known to have such problems across different framework versions ways of referencing it
The original warning is:
ASPNETCOMPILER : error : The following assembly has dependencies on a version of the .NET Framework that is higher than the target and might not load correctly during runtime causing a failure: Orchard.Workflows, Version=1.10.3.0, Culture=neutral, PublicKeyToken=null. The dependencies are: System.Net.Http, Version=4.2.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a. You should either ensure that the dependent assembly is correct for the target framework, or ensure that the target framework you are addressing is that of the dependent assembly. [D:\a\Orchard\Orchard\src\Orchard.Web\Modules\Orchard.Workflows\Orchard.Workflows.csproj
* Re-enabling the Test step
* Re-enabling the Specs step
* Marking System.Net.Http references as private (copy local) to make sure that it's always available, because it requires a specific version
* Revert "Marking System.Net.Http references as private (copy local) to make sure that it's always available, because it requires a specific version"
This reverts commit e4f5632236.
* Orchard.Specs: Adding Settings feature
* Orchard.Specs: Updating DateTime.CreatingAndUsingDateTimeFieldsInAnotherCulture structure without functional change
* Orchard.Specs: Updating Settings.AddingANewSiteCultureAndSelectingItAsTheDefaultWorks to correctly detect that a culture that wasn't added before can be set as default
* Fixing Newtonsoft.Json references
* Specs: Workaround for the DefineDefaultCulture binding and removing the Settings feature which is now redundant with CreatingAndUsingDateTimeFieldsInAnotherCulture
* Updating the compile workflow to run the build + tests on PR, dev and 1.10.x commits
* Adding the compile workflow to the solution
* Checked back previously selected terms after replacing the TaxonomyField markup.
* Checkbox reset before checking back selected items.
* Javascript functions to refresh localized terms are now named to be unique. For this purpose, added PartName property to LocalizedTaxonomiesViewModel.
* Code refactoring: added variables for part-field differentiator and function name.
* Adds the ability to create links based on orchard contents, calculating href during the display process using tokens
# Conflicts:
# src/Orchard.Web/Modules/TinyMce/Scripts/orchard-tinymce.js
* Adds Contentmanager.Get Tokens
Adds Content Links plugin to TinyMCE
* Adds settings for TextField and BodyPart in order to specify which content types or part to show in the list
* Settings for Html editors built on BodyParts, TextFields, LayoutParts
* Adds minified version of the plugin.js
* Tests if dependencies are enabled before activating the content links settings
* new .png for TinyMce
* Renamed the token as suggested during last meeting
* Added no term selection option when taxonomy field is not required and is set to be shown as a radio button set (single choice without autocomplete)
* Correctly checked the "no selection" option when SingleTermId == 0.
* If no term with the proper culture is found, SingleTermId is the id of the first valid checked term.
* Correction on firstTermForCulture query if there is no LocalizationPart.
Simplified query to check selected terms.
* Added Role Event Activities and Handlers for workflows.
* Removed and sorted using
* Added user as the Content parameter for worflow triggers when possible (UserAdded and UserRemoved role events).
* Added Username policies
* Added newline at the end of files
# Conflicts:
# src/Orchard.Web/Modules/Orchard.Users/Services/AccountValidationService.cs
* Added check for username length that must be under 255 characters (even if username policies are disabled).
If username isn't modified, policies are not enforced when saving the user inside backoffice.
Default length limits are 1 and 255.
* Added UsernameValidationError.cs
Added a setting to bypass non fatal errors and show them as warning when creating/editing users from the backoffice
Added the relative checkbox in RegistrationSettings.cshtml
Modified the UsernameMeetsPolicies method to use the new class
Modified AdminController (CreatePOST, EditPOST) and AccountController (Register)
* If username is an email check that it matches the specified email
* Added hints to UserRegistrationSettings view
Changed the severity of some custom policies errors
* Removed UsernameValidLengthAttribute.cs, if MinimumUsernameLength and MaximumUsernameLength settings don't make sense these settings are ignored
* bugfix. The admin could change the a username setting an already existing username.
Co-authored-by: Andrea Piovanelli <andrea.piovanelli@laser-group.com>
* Added hint in EditField view
* Added hint to EditTypeViewModel.cshtml to show technical name in list of content types
* fixed typo
* Clarified hint displaying technical name.
Co-authored-by: Andrea Piovanelli <andrea.piovanelli@laser-group.com>
* If there is nothing to import for MediaLibraryPickerField and ContentPickerField, the field doesn't need to be reset.
* Checked the presence of the field inside the import context to avoid resetting the field value even if the field isn't imported.
This applies to ContentPickerField, MediaLibraryPickerField and NumericField.
* Parameter validation for ChangeExpiredPassword action. Centralized check for
password expiration.
* Added ForcePasswordChange flag check to redirect to the correct page when that flag is true.
Co-authored-by: Andrea Piovanelli <andrea.piovanelli@laser-group.com>
* Added null check for last password change date. If that is null, use user date creation to check for password expiration.
* Added nullable date checks in AccountController ChangeExpiredPassword action too.
* Added nullable type to DescribeMemberContext for BooleanField and NumericField.
* Rollback of nullable member value for NumericFieldDriver, which is unnecessary because Editor function doesn't let a null value to be saved.
