* Upgrading projects, code generation templates and Specflow app to use Microsoft.CodeDom.Providers.DotNetCompilerPlatform 4.1.0 (latest)
* Updating csprojs not to define LangVersion separately in Release and Debug mode, setting it to "default" instead of "latest"
* Restricting C# language version to 7.3
* Downgrading SmtpMessageChannel.cs to C# 7.3
* Setting MvcBuildViews = false in the remaining csprojs that reference DotNetCompilerPlatform, like the others
* Setting RoslynCopyToOutDir = false in each csproj that references DotNetCompilerPlatform
See https://github.com/aspnet/RoslynCodeDomProvider?tab=readme-ov-file#build-time-options
- We only need Orchard.Web to include the Roslyn tools in its bin folder, the other csprojs only need the DLL reference
- We could simply remove the targets import in these csprojs, but it will be re-added when the package is updated, so this is cleaner/easier
* We don't actually need <MvcBuildViews>false</MvcBuildViews> in csprojs
* Orchard.Web: Copying Roslyn files to the output folder using the provided target (CopyRoslynCompilerFilesToOutputDirectory) instead of our custom one
* Orchard.proj: Factoring out a part of the Compile target into the DevCompile target and removing BuildViews target
- For a simple local build (just to validate that the solution builds), we don't actually need that second build that copies files to the output folder.
- CI builds (Test, Spec, etc.) that operate on the build output folder are unaffected, because Compile calls DevCompile
- The BuildViews target is not really necessary, just call any other target (Compile, DevCompile, Spec, etc.) with "/p:MvcBuildViews=true"
* Removing incorrect comment about Razor IntelliSense
* Removing VBCodeProvider configuration from Web.config files
* Getting rid of Microsoft.CodeDom.Providers.DotNetCompilerPlatform.targets imports and associated configuration except in Orchard.Web.csproj
* Adding VB compiler configuration to src/Orchard.Web/Web.config, because it would be readded on rebuild by the imported target anyway
* Using MailKit instead of SmtpClient
* Removing 2 more references to System.Net.Http that we hopefully don't need at all anymore
* Attempting to fix Razor compilation warning about Orchard.Email's reference to System.Net.Http
* Improving SmtpSettings.cshtml a bit (port number restrictions, user name box width)
* Fixing encription method is not persisted
* Adding migration step to migrate from EnableSsl to EncryptionMethod in SmtpSettingsPart
* Code styling/simplifications
* Using infoset default values instead of Migrations to keep SSL settings when upgrading to MailKit
---------
Co-authored-by: Lombiq <github@lombiq.com>
Co-authored-by: Benedek Farkas <benedek.farkas@lombiq.com>
* Fixing that RecipeManagerTests failed due to HttpContext not being available
* Fixing OwnerEditor tests in CommonPartProviderTests as the owner editor now checks for a different permission since 5b0c82d1ad
* Fixing typo in CommonPartProviderTests.UpdateModelStub class name
* Fixing that test cases for invalid path in FileSystemStorageProviderTests broke in a3e9bef3ca (issue #6802, PR #6919)
I should review PRs more carefully!
* Fixing CurrentCultureWorkContextTests
* Fixing indentation in DefaultDateFormatterTests
* Updating Orchard.Azure.Web's required version of System.Web.Mvc to match the rest of the solution
* Orchard.Specs: Fixing assembly loading errors when starting up the web host by adding binding redirects
* Adding empty compile workflow from dev
* Adding the compile workflow's actual contents
* Changing default shell to pwsh (msbuild was not found in cmd?)
* Adding msbuild to PATH
* Removing unused references to System.Net.Http
* Replacing System.Net.Http references with its NuGet package to pin the correct version number (experimental)
* Upgrading Microsoft.CodeDom.Providers.DotNetCompilerPlatform to 4.1.0 (latest) to get rid of old System.Http.Net dependency
* Orchard.proj: Spec target actually depends on only the Compile target, not Package-Stage (experimental)
* Compile workflow: Testing the Test and Spec targets
* Fixing Test step
* Fixing compile workflow to also mark Razor compilation warnings as errors
* Restoring Orchard.Specs/Hosting/Orchard.Web/Web.config to match Orchard.Web's web.config closer
so that it loads assemblies from the Dependencies folder.
This fixes the error with Autofac not being able to resolve dependencies for DefaultOrchardShell
* Orchard.Specs/Hosting/Orchard.Web/Global.asax.cs: Workaround for AntiForgeryToken bug in ASP.NET MVC since version 5.2.4
https://github.com/aspnet/AspNetWebStack/issues/162
* Revert "Replacing System.Net.Http references with its NuGet package to pin the correct version number (experimental)"
This reverts commit 087f2849b1.
* Revert "Upgrading Microsoft.CodeDom.Providers.DotNetCompilerPlatform to 4.1.0 (latest) to get rid of old System.Http.Net dependency"
This reverts commit be2ba866e3.
* Reverting the addition of assembly binding redirects to Orchard.Specs/Hosting/Simple.Web/Web.config
since it doesn't need them like Orchard.Specs/Hosting/Orchard.Web/Web.config does
* Disabling Test and Spec execution for now
* Orchard.Framework: Making the System.Net.Http not-private to prevent an outdated version sticking around
* Orchard.Workflows: Adding assembly binding redirect for System.Net.Http to avoid Razor compilation warning
* Moving the System.Net.Http assembly redirect to Orchard.Web
* Specs: Fixing "I can create browse blog posts on several pages" Blog test's usage of "I should not see" and correcting the parameters too
because unlike "I should see", this is not a regex match, just contains
* Specs: Fixing "I can create browse blog posts on several pages" Blog test's flakyness due to timing
because the blog posts are created quickly after one another and the lack of millisecond-precision can cause
the blog posts to appear out of order of creation
* Specs: Media test simplified since the Orchard.Media feature is deprecated
* Adding step to the Compile workflow to upload the MSBuild binlog results
* Pinning the referenced version of System.Net.Http to 4.2.0.0 to prevent Razor compilation warning
System.Net.Http is known to have such problems across different framework versions ways of referencing it
The original warning is:
ASPNETCOMPILER : error : The following assembly has dependencies on a version of the .NET Framework that is higher than the target and might not load correctly during runtime causing a failure: Orchard.Workflows, Version=1.10.3.0, Culture=neutral, PublicKeyToken=null. The dependencies are: System.Net.Http, Version=4.2.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a. You should either ensure that the dependent assembly is correct for the target framework, or ensure that the target framework you are addressing is that of the dependent assembly. [D:\a\Orchard\Orchard\src\Orchard.Web\Modules\Orchard.Workflows\Orchard.Workflows.csproj
* Re-enabling the Test step
* Re-enabling the Specs step
* Marking System.Net.Http references as private (copy local) to make sure that it's always available, because it requires a specific version
* Revert "Marking System.Net.Http references as private (copy local) to make sure that it's always available, because it requires a specific version"
This reverts commit e4f5632236.
* Orchard.Specs: Adding Settings feature
* Orchard.Specs: Updating DateTime.CreatingAndUsingDateTimeFieldsInAnotherCulture structure without functional change
* Orchard.Specs: Updating Settings.AddingANewSiteCultureAndSelectingItAsTheDefaultWorks to correctly detect that a culture that wasn't added before can be set as default
* Fixing Newtonsoft.Json references
* Specs: Workaround for the DefineDefaultCulture binding and removing the Settings feature which is now redundant with CreatingAndUsingDateTimeFieldsInAnotherCulture
* Updating the compile workflow to run the build + tests on PR, dev and 1.10.x commits
* Adding the compile workflow to the solution
* Upgraded NHibernate to version 5.3.10. Solution builds with no warnings.
* fixed most issues
* Added source code for NHibernate.Linq library from
http://sourceforge.net/projects/nhcontrib/files/NHibernate.Linq/1.0/NHibernate.Linq-1.0.0.GA-src.zip
With the modified DetachedCriteriaAdapter.cs for Orchard.
Started upgrading that library to NHibernate 5.3.10.
* Finished updating NHibernate.Linq to work with NHibernate 5.3.10.
* Removed NHibernate.Linq from lib folder
* Updated code generation templates to use the correct version of nhibernate
* Added tokenizable default value to ContentPickerFields (#8351)
* Fixes errors during Indexing (#8349)
* Added admin search permissions (#8346)
* Reuse Settings_ShellDescriptorRecord during an http request (#8355)
* Added a new index to CommonPartRecord (#8362)
* Attempted AutoroutePart improvement (#8360)
This should ease Database issues, because it short circuits some code paths
through aliases.
* Save MemberBindingRecords in memory (#8371)
Prevent fetching the same table from the database 5+ times per request by
loading it and saving it in a private property for a request.
* Cache list of configured layers (#8373)
On every page load on frontend we were querying for all existing layers to test
for the ones that are currently active. Since that information is not bound to
change often, we added a cache layer to prevent querying every time. The cache
is evicted whenever a Layer gets updated.
* Memorize query results in blog service (#8374)
The query for all published blogs is being called twice while building the admin menu,
so we are memorizing its results.
* Updated UI for projections (#8380)
Some textboxes were too small for the actual text users would generally write in them.
Those meant to hold HTML have been converted to textareas.
* Process ignored paths while being aware of RequestUrlPrefix (#8384)
* Process ignored paths while being aware of RequestUrlPrefix
* Fix: I had moved a Trim to the wrong place
* Fixed issue with empty/uninitialized null set of ignored urls
* tokens sort criteria (#8382)
* Tokenized state for sort criteria
* Tokenized state also in the other place where sort criteria are used
* Remove lock from the dictionary when the task has completed. (#8395)
Fixes#8391
* Update DistributedLockService.cs (#8398)
* fix for CPF when other scripts are also adding to sessionStorage (#8404)
* Fixes Boolean Conversion error (#8393)
* Fix/8392 remeber me model state exception (#8410)
@sebastienros this fixes the possible NRE that would happen for absent models from merged #8393
(see your comment there https://github.com/OrchardCMS/Orchard/pull/8393#issuecomment-686630198)
* Removed changes to model bindings (#8412)
This is the same as reverting 1.10.x to commit 868ce12ad6
* New version of Boolean Binder Provider (#8413)
* New version of Boolean Binder Provider
* Use Convert.ToBoolean(string) rather than ValueProviderResult.ConvertTo(bool)
* Upgrade host resolution (#8387)
* Reverted changes to RunningShellTable and then changed the way shells are sorted,
so we can correctly give "priority" to tenants based on their prefix.
Added test adapter reference to Orchard.Framework.Tests so tests can be run in
the latest VS 2017.
Fixed a test that was failing to account for the order the shells were being
processed.
* Removed some stuff from csproj that vs had added
* Handle the case where a form sends more than one attempted value for a boolean (#8416)
* fix record mapping nhibernate (#8415)
* Allow downstream methods to set default value (#8419)
Moreover, this won't try to set a default value to the bool when it's not sent.
This will allow calls with missing required parameters to fail as they should.
* Fixed Media Library Picker Style (#8433)
* Removed check preventing reassignment of loader delegates (#8436)
* Added an event activity for workflows that activates on the first Upd… (#8438)
* target framework 4.8 to all projects (#8444)
* Feature/8445 libraries update (#8446)
* Fixed conflict with style for layouts (#8456)
the .overlay is used for different things in MediaLibraryPickerField and Layouts, and as it was the styles would conflict. This should fix it.
* Feature/upgradable libraries (#8457)
* Updated Migration for CommonPartRecord and IdentityPartRecord (#8459)
This orders the operations differently than what is in dev for retrocompatibility in both environments.
* Prevents throwing exception when Href is null (#8461)
* added culture in widgets page (#8466)
* added culture in widgets page
Co-authored-by: elena.lampugnani <elena.lampugnani@laser-group.com>
Co-authored-by: Hermes Sbicego <hermes.sbicego@laser-group.com>
* Show disable action for deprecated features even if they are categorized as "Core" (#8468)
* Upgrades YamlDotNet from 9.1.3 to 11.1.1 because 9.1.3 is not more available as nuget package (#8472)
* Bypass cache for XSRF Tokens (#8470)
Fixes#8469
* flag exclude children for taxonomies (#8481)
* Remove cache by tag on Unpublished (#8483)
As it was, cached lists/projections would not be evicted when a ContentItem they contained was unpublished.
* Cloning doesn't overwrite identity (#8487)
Fixes#8486
* Update nhibernate (#8488)
* Update nHibernate to version 4.1.2.4000
# Conflicts:
# src/Orchard.Web/Modules/Orchard.ContentPicker/packages.config
# src/Orchard.Web/Modules/Orchard.ImportExport/packages.config
# src/Orchard.Web/Modules/Orchard.MessageBus/packages.config
# src/Orchard.Web/Modules/Orchard.MultiTenancy/packages.config
# src/Orchard.Web/Modules/Orchard.Projections/packages.config
# src/Orchard.Web/Modules/Orchard.Tags/packages.config
# src/Orchard.Web/Modules/Upgrade/packages.config
# src/Orchard.Web/Web.config
* Update AssemblyBindings for NHibernate
* Fixes disposed LifetimeScope issue (#8490)
* fixed scope in in recomputing the context to figure out whether an antiforgery token needs replacing
* Revert "Cloning doesn't overwrite identity (#8487)" (#8495)
This reverts commit af42947c9c.
* Remove whitespace when importing list of permissions (#8499)
Similarly to what's already being done when we import features.
this allows to go to a new line in the xml that we import, and even tabulate for readability and maintenance.
* Force enumeration of list of permissions.
Without this, imported permissions (#8492) would always replace existing ones: i.e. if an existing permission is not in
the list being imported it would be removed for the role.
* Projection default settings (#8497)
* added settings in projection part
* read settings into driver
* commit files setting
* add logic of filter query
* added logic of filter query setting
* managed import/export
* fixed migration
* added message information
Co-authored-by: elena.lampugnani <elena.lampugnani@laser-group.com>
* HtmlDecode token (#8501)
Added HtmlDecode token management.
Needed for #8500
* Sets SSL redirection as permanent for SEO reasons (#8503)
Fixes#8502
* Added null checks (#8511)
The added null checks manage properly importing definitions that do not contain the properties.
* Fix/editmenulink (#8515)
* Removed useless spaces
* Corrections on ProjectionPart query link (it didn't update the link when changing the selected query).
Added edit link for menu in MenuWidget.
* Added menuId parameter to menu edit link
* Fixed various typos: (#8512)
* Added descriptor to audit trail context (#8517)
Co-authored-by: Hermes Sbicego <hermes.sbicego@laser-group.com>
Co-authored-by: Imran Azad <imranazad@users.noreply.github.com>
Co-authored-by: LorenzoFrediani-Laser <lorenzo.frediani@laser-group.com>
Co-authored-by: ElenaRepository <50620495+ElenaRepository@users.noreply.github.com>
Co-authored-by: Andrea Piovanelli <83577153+AndreaPiovanelliLaser@users.noreply.github.com>
* Reverted changes to RunningShellTable and then changed the way shells are sorted,
so we can correctly give "priority" to tenants based on their prefix.
Added test adapter reference to Orchard.Framework.Tests so tests can be run in
the latest VS 2017.
Fixed a test that was failing to account for the order the shells were being
processed.
* Removed some stuff from csproj that vs had added
