diff --git a/src/Orchard.Tests.Modules/Packaging/PackageBuilderTests.cs b/src/Orchard.Tests.Modules/Packaging/PackageBuilderTests.cs index 1574027f7..c027ec556 100644 --- a/src/Orchard.Tests.Modules/Packaging/PackageBuilderTests.cs +++ b/src/Orchard.Tests.Modules/Packaging/PackageBuilderTests.cs @@ -31,7 +31,7 @@ namespace Orchard.Tests.Modules.Packaging { return packageBuilder.BuildPackage(new ExtensionDescriptor { ExtensionType = "Module", - Name = "Hello.World", + Id = "Hello.World", Version = "1.0", Description = "a", Author = "b" diff --git a/src/Orchard.Tests.Modules/Packaging/PackageExpanderTests.cs b/src/Orchard.Tests.Modules/Packaging/PackageExpanderTests.cs index f5d3a96fa..ad8100586 100644 --- a/src/Orchard.Tests.Modules/Packaging/PackageExpanderTests.cs +++ b/src/Orchard.Tests.Modules/Packaging/PackageExpanderTests.cs @@ -28,7 +28,7 @@ namespace Orchard.Tests.Modules.Packaging { private Stream BuildHelloWorld(IPackageBuilder packageBuilder) { return packageBuilder.BuildPackage(new ExtensionDescriptor { ExtensionType = "Module", - Name = "Hello.World", + Id = "Hello.World", Version = "1.0", Description = "a", Author = "b" diff --git a/src/Orchard.Tests/DataMigration/DataMigrationTests.cs b/src/Orchard.Tests/DataMigration/DataMigrationTests.cs index 903e85c5f..0fd11395a 100644 --- a/src/Orchard.Tests/DataMigration/DataMigrationTests.cs +++ b/src/Orchard.Tests/DataMigration/DataMigrationTests.cs @@ -96,19 +96,19 @@ namespace Orchard.Tests.DataMigration { public class DataMigrationEmpty : IDataMigration { public Feature Feature { - get { return new Feature() {Descriptor = new FeatureDescriptor() {Name = "Feature1"}}; } + get { return new Feature() {Descriptor = new FeatureDescriptor() {Id = "Feature1"}}; } } } public class DataMigration11 : IDataMigration { public Feature Feature { - get { return new Feature() {Descriptor = new FeatureDescriptor() {Name = "Feature1"}}; } + get { return new Feature() {Descriptor = new FeatureDescriptor() {Id = "Feature1"}}; } } } public class DataMigration11Create : IDataMigration { public Feature Feature { - get { return new Feature() {Descriptor = new FeatureDescriptor() {Name = "Feature1"}}; } + get { return new Feature() {Descriptor = new FeatureDescriptor() {Id = "Feature1"}}; } } public int Create() { @@ -118,7 +118,7 @@ namespace Orchard.Tests.DataMigration { public class DataMigrationCreateCanBeFollowedByUpdates : IDataMigration { public Feature Feature { - get { return new Feature() { Descriptor = new FeatureDescriptor() { Name = "Feature1" } }; } + get { return new Feature() { Descriptor = new FeatureDescriptor() { Id = "Feature1" } }; } } public int Create() { @@ -132,7 +132,7 @@ namespace Orchard.Tests.DataMigration { public class DataMigrationSameMigrationClassCanEvolve : IDataMigration { public Feature Feature { - get { return new Feature() { Descriptor = new FeatureDescriptor() { Name = "Feature1" } }; } + get { return new Feature() { Descriptor = new FeatureDescriptor() { Id = "Feature1" } }; } } public int Create() { @@ -150,7 +150,7 @@ namespace Orchard.Tests.DataMigration { public class DataMigrationDependenciesModule1 : IDataMigration { public Feature Feature { - get { return new Feature() {Descriptor = new FeatureDescriptor() {Name = "Feature1"}}; } + get { return new Feature() {Descriptor = new FeatureDescriptor() {Id = "Feature1"}}; } } public int Create() { @@ -160,7 +160,7 @@ namespace Orchard.Tests.DataMigration { public class DataMigrationDependenciesModule2 : IDataMigration { public Feature Feature { - get { return new Feature() { Descriptor = new FeatureDescriptor() { Name = "Feature2" } }; } + get { return new Feature() { Descriptor = new FeatureDescriptor() { Id = "Feature2" } }; } } public int Create() { @@ -170,7 +170,7 @@ namespace Orchard.Tests.DataMigration { public class DataMigrationWithSchemaBuilder : DataMigrationImpl { public override Feature Feature { - get { return new Feature() { Descriptor = new FeatureDescriptor() { Name = "Feature1" } }; } + get { return new Feature() { Descriptor = new FeatureDescriptor() { Id = "Feature1" } }; } } public int Create() { @@ -181,13 +181,13 @@ namespace Orchard.Tests.DataMigration { public class DataMigrationFeatureNeedUpdate1 : IDataMigration { public Feature Feature { - get { return new Feature() { Descriptor = new FeatureDescriptor() { Name = "Feature1" } }; } + get { return new Feature() { Descriptor = new FeatureDescriptor() { Id = "Feature1" } }; } } } public class DataMigrationFeatureNeedUpdate2 : IDataMigration { public Feature Feature { - get { return new Feature() { Descriptor = new FeatureDescriptor() { Name = "Feature2" } }; } + get { return new Feature() { Descriptor = new FeatureDescriptor() { Id = "Feature2" } }; } } public int Create() { @@ -197,7 +197,7 @@ namespace Orchard.Tests.DataMigration { public class DataMigrationFeatureNeedUpdate3 : IDataMigration { public Feature Feature { - get { return new Feature() { Descriptor = new FeatureDescriptor() { Name = "Feature3" } }; } + get { return new Feature() { Descriptor = new FeatureDescriptor() { Id = "Feature3" } }; } } public int Create() { @@ -211,7 +211,7 @@ namespace Orchard.Tests.DataMigration { public class DataMigrationSimpleBuilder : DataMigrationImpl { public override Feature Feature { - get { return new Feature() { Descriptor = new FeatureDescriptor() { Name = "Feature1" } }; } + get { return new Feature() { Descriptor = new FeatureDescriptor() { Id = "Feature1" } }; } } public int Create() { diff --git a/src/Orchard.Tests/DisplayManagement/DefaultDisplayManagerTests.cs b/src/Orchard.Tests/DisplayManagement/DefaultDisplayManagerTests.cs index 1a770a385..12411c51e 100644 --- a/src/Orchard.Tests/DisplayManagement/DefaultDisplayManagerTests.cs +++ b/src/Orchard.Tests/DisplayManagement/DefaultDisplayManagerTests.cs @@ -23,7 +23,7 @@ namespace Orchard.Tests.DisplayManagement { Bindings = new Dictionary(StringComparer.OrdinalIgnoreCase) }; _workContext = new TestWorkContext { - CurrentTheme = new ExtensionDescriptor { Name = "Hello" } + CurrentTheme = new ExtensionDescriptor { Id = "Hello" } }; diff --git a/src/Orchard.Tests/DisplayManagement/Descriptors/DefaultShapeTableManagerTests.cs b/src/Orchard.Tests/DisplayManagement/Descriptors/DefaultShapeTableManagerTests.cs index b17dab732..84bbb7177 100644 --- a/src/Orchard.Tests/DisplayManagement/Descriptors/DefaultShapeTableManagerTests.cs +++ b/src/Orchard.Tests/DisplayManagement/Descriptors/DefaultShapeTableManagerTests.cs @@ -18,24 +18,24 @@ namespace Orchard.Tests.DisplayManagement.Descriptors { var features = new [] { new FeatureDescriptor { - Name = "Theme1", + Id = "Theme1", Extension = new ExtensionDescriptor { - Name = "Theme1", + Id = "Theme1", ExtensionType = "Theme" } }, new FeatureDescriptor { - Name = "DerivedTheme", + Id = "DerivedTheme", Extension = new ExtensionDescriptor { - Name = "DerivedTheme", + Id = "DerivedTheme", ExtensionType = "Theme", BaseTheme = "BaseTheme" } }, new FeatureDescriptor { - Name = "BaseTheme", + Id = "BaseTheme", Extension = new ExtensionDescriptor { - Name = "BaseTheme", + Id = "BaseTheme", ExtensionType = "Theme" } } @@ -65,10 +65,10 @@ namespace Orchard.Tests.DisplayManagement.Descriptors { static Feature TestFeature() { return new Feature { Descriptor = new FeatureDescriptor { - Name = "Testing", + Id = "Testing", Dependencies = Enumerable.Empty(), Extension = new ExtensionDescriptor { - Name = "Testing", + Id = "Testing", ExtensionType = "Module", } } @@ -107,7 +107,7 @@ namespace Orchard.Tests.DisplayManagement.Descriptors { void IShapeTableProvider.Discover(ShapeTableBuilder builder) { foreach (var pair in FeatureShapes) { foreach (var shape in pair.Value) { - builder.Describe(shape).From(pair.Key).BoundAs(pair.Key.Descriptor.Name, null); + builder.Describe(shape).From(pair.Key).BoundAs(pair.Key.Descriptor.Id, null); } } Discover(builder); diff --git a/src/Orchard.Tests/DisplayManagement/Descriptors/ShapeAttributeBindingStrategyTests.cs b/src/Orchard.Tests/DisplayManagement/Descriptors/ShapeAttributeBindingStrategyTests.cs index 5512a4d1c..17dd8927c 100644 --- a/src/Orchard.Tests/DisplayManagement/Descriptors/ShapeAttributeBindingStrategyTests.cs +++ b/src/Orchard.Tests/DisplayManagement/Descriptors/ShapeAttributeBindingStrategyTests.cs @@ -26,9 +26,9 @@ namespace Orchard.Tests.DisplayManagement.Descriptors { builder.RegisterAutoMocking(); _testFeature = new Feature { Descriptor = new FeatureDescriptor { - Name = "Testing", + Id = "Testing", Extension = new ExtensionDescriptor { - Name = "Testing", + Id = "Testing", ExtensionType = "Module", } } diff --git a/src/Orchard.Tests/DisplayManagement/Descriptors/ShapeTemplateBindingStrategyTests.cs b/src/Orchard.Tests/DisplayManagement/Descriptors/ShapeTemplateBindingStrategyTests.cs index 99be41cb6..d842d9bda 100644 --- a/src/Orchard.Tests/DisplayManagement/Descriptors/ShapeTemplateBindingStrategyTests.cs +++ b/src/Orchard.Tests/DisplayManagement/Descriptors/ShapeTemplateBindingStrategyTests.cs @@ -62,10 +62,10 @@ namespace Orchard.Tests.DisplayManagement.Descriptors { void AddFeature(string name, params string[] dependencies) { var featureDescriptor = new FeatureDescriptor { - Name = name, + Id = name, Dependencies = dependencies, Extension = new ExtensionDescriptor { - Name = name, + Id = name, Location = "~/Modules" } }; diff --git a/src/Orchard.Tests/DisplayManagement/SubsystemTests.cs b/src/Orchard.Tests/DisplayManagement/SubsystemTests.cs index 685a99fce..953958392 100644 --- a/src/Orchard.Tests/DisplayManagement/SubsystemTests.cs +++ b/src/Orchard.Tests/DisplayManagement/SubsystemTests.cs @@ -24,10 +24,10 @@ namespace Orchard.Tests.DisplayManagement { { Descriptor = new FeatureDescriptor { - Name = "Testing", + Id = "Testing", Extension = new ExtensionDescriptor { - Name = "Testing", + Id = "Testing", ExtensionType = "Module", } } @@ -35,7 +35,7 @@ namespace Orchard.Tests.DisplayManagement { var workContext = new DefaultDisplayManagerTests.TestWorkContext { - CurrentTheme = new ExtensionDescriptor { Name = "Hello" } + CurrentTheme = new ExtensionDescriptor { Id = "Hello" } }; var builder = new ContainerBuilder(); diff --git a/src/Orchard.Tests/Environment/DefaultCompositionStrategyTests.cs b/src/Orchard.Tests/Environment/DefaultCompositionStrategyTests.cs index 6898c4a0d..6cc4c218c 100644 --- a/src/Orchard.Tests/Environment/DefaultCompositionStrategyTests.cs +++ b/src/Orchard.Tests/Environment/DefaultCompositionStrategyTests.cs @@ -49,7 +49,7 @@ namespace Orchard.Tests.Environment { private IEnumerable StubLoadFeatures(IEnumerable featureDescriptors) { return featureDescriptors.Select(featureDescriptor => new Feature { Descriptor = featureDescriptor, - ExportedTypes = _featureTypes[featureDescriptor.Name] + ExportedTypes = _featureTypes[featureDescriptor.Id] }); } @@ -88,11 +88,11 @@ namespace Orchard.Tests.Environment { var foo = blueprint.Dependencies.SingleOrDefault(t => t.Type == typeof(FooService1)); Assert.That(foo, Is.Not.Null); - Assert.That(foo.Feature.Descriptor.Name, Is.EqualTo("Foo")); + Assert.That(foo.Feature.Descriptor.Id, Is.EqualTo("Foo")); var bar = blueprint.Dependencies.SingleOrDefault(t => t.Type == typeof(BarService1)); Assert.That(bar, Is.Not.Null); - Assert.That(bar.Feature.Descriptor.Name, Is.EqualTo("Bar")); + Assert.That(bar.Feature.Descriptor.Id, Is.EqualTo("Bar")); } public interface IFooService : IDependency { @@ -149,8 +149,8 @@ namespace Orchard.Tests.Environment { var alpha = blueprint.Dependencies.Single(x => x.Type == typeof(AlphaModule)); var beta = blueprint.Dependencies.Single(x => x.Type == typeof(BetaModule)); - Assert.That(alpha.Feature.Descriptor.Name, Is.EqualTo("Foo")); - Assert.That(beta.Feature.Descriptor.Name, Is.EqualTo("Bar")); + Assert.That(alpha.Feature.Descriptor.Id, Is.EqualTo("Foo")); + Assert.That(beta.Feature.Descriptor.Id, Is.EqualTo("Bar")); } public class AlphaModule : Module { @@ -183,15 +183,15 @@ namespace Orchard.Tests.Environment { var delta = blueprint.Controllers.Single(x => x.Type == typeof(DeltaController)); var epsilon = blueprint.Controllers.Single(x => x.Type == typeof(EpsilonController)); - Assert.That(gamma.Feature.Descriptor.Name, Is.EqualTo("Foo Plus")); + Assert.That(gamma.Feature.Descriptor.Id, Is.EqualTo("Foo Plus")); Assert.That(gamma.AreaName, Is.EqualTo("MyCompany.Foo")); Assert.That(gamma.ControllerName, Is.EqualTo("Gamma")); - Assert.That(delta.Feature.Descriptor.Name, Is.EqualTo("Bar Minus")); + Assert.That(delta.Feature.Descriptor.Id, Is.EqualTo("Bar Minus")); Assert.That(delta.AreaName, Is.EqualTo("Bar")); Assert.That(delta.ControllerName, Is.EqualTo("Delta")); - Assert.That(epsilon.Feature.Descriptor.Name, Is.EqualTo("Bar Minus")); + Assert.That(epsilon.Feature.Descriptor.Id, Is.EqualTo("Bar Minus")); Assert.That(epsilon.AreaName, Is.EqualTo("Bar")); Assert.That(epsilon.ControllerName, Is.EqualTo("Epsilon")); } @@ -233,10 +233,10 @@ namespace Orchard.Tests.Environment { var foo = blueprint.Records.Single(x => x.Type == typeof(FooRecord)); var bar = blueprint.Records.Single(x => x.Type == typeof(BarRecord)); - Assert.That(foo.Feature.Descriptor.Name, Is.EqualTo("Foo Plus")); + Assert.That(foo.Feature.Descriptor.Id, Is.EqualTo("Foo Plus")); Assert.That(foo.TableName, Is.EqualTo("MyCompany_Foo_FooRecord")); - Assert.That(bar.Feature.Descriptor.Name, Is.EqualTo("Bar")); + Assert.That(bar.Feature.Descriptor.Id, Is.EqualTo("Bar")); Assert.That(bar.TableName, Is.EqualTo("Bar_BarRecord")); } @@ -251,13 +251,13 @@ namespace Orchard.Tests.Environment { var ci = blueprint.Records.Single(x => x.Type == typeof(ContentItemRecord)); var civ = blueprint.Records.Single(x => x.Type == typeof(ContentItemVersionRecord)); - Assert.That(ct.Feature.Descriptor.Name, Is.EqualTo("Orchard.Framework")); + Assert.That(ct.Feature.Descriptor.Id, Is.EqualTo("Orchard.Framework")); Assert.That(ct.TableName, Is.EqualTo("Orchard_Framework_ContentTypeRecord")); - Assert.That(ci.Feature.Descriptor.Name, Is.EqualTo("Orchard.Framework")); + Assert.That(ci.Feature.Descriptor.Id, Is.EqualTo("Orchard.Framework")); Assert.That(ci.TableName, Is.EqualTo("Orchard_Framework_ContentItemRecord")); - Assert.That(civ.Feature.Descriptor.Name, Is.EqualTo("Orchard.Framework")); + Assert.That(civ.Feature.Descriptor.Id, Is.EqualTo("Orchard.Framework")); Assert.That(civ.TableName, Is.EqualTo("Orchard_Framework_ContentItemVersionRecord")); } @@ -283,10 +283,10 @@ namespace Orchard.Tests.Environment { var foo = blueprint.Records.Single(x => x.Type == typeof(FooRecord)); var bar = blueprint.Records.Single(x => x.Type == typeof(BarRecord)); - Assert.That(foo.Feature.Descriptor.Name, Is.EqualTo("Foo Plus")); + Assert.That(foo.Feature.Descriptor.Id, Is.EqualTo("Foo Plus")); Assert.That(foo.TableName, Is.EqualTo("Yadda_MyCompany_Foo_FooRecord")); - Assert.That(bar.Feature.Descriptor.Name, Is.EqualTo("Bar")); + Assert.That(bar.Feature.Descriptor.Id, Is.EqualTo("Bar")); Assert.That(bar.TableName, Is.EqualTo("Yadda_Bar_BarRecord")); } diff --git a/src/Orchard.Tests/Environment/DefaultOrchardHostTests.cs b/src/Orchard.Tests/Environment/DefaultOrchardHostTests.cs index ff9b4571b..62595efc4 100644 --- a/src/Orchard.Tests/Environment/DefaultOrchardHostTests.cs +++ b/src/Orchard.Tests/Environment/DefaultOrchardHostTests.cs @@ -90,8 +90,8 @@ namespace Orchard.Tests.Environment { } public IEnumerable AvailableExtensions() { - var ext = new ExtensionDescriptor { Name = "Orchard.Framework" }; - ext.Features = new[] { new FeatureDescriptor { Extension = ext, Name = ext.Name } }; + var ext = new ExtensionDescriptor { Id = "Orchard.Framework" }; + ext.Features = new[] { new FeatureDescriptor { Extension = ext, Id = ext.Id } }; yield return ext; } @@ -102,7 +102,7 @@ namespace Orchard.Tests.Environment { public IEnumerable LoadFeatures(IEnumerable featureDescriptors) { foreach (var descriptor in featureDescriptors) { - if (descriptor.Name == "Orchard.Framework") { + if (descriptor.Id == "Orchard.Framework") { yield return FrameworkFeature(descriptor); } } diff --git a/src/Orchard.Tests/Environment/Extensions/ExtensionFoldersTests.cs b/src/Orchard.Tests/Environment/Extensions/ExtensionFoldersTests.cs index c80d090f6..3177a4cb5 100644 --- a/src/Orchard.Tests/Environment/Extensions/ExtensionFoldersTests.cs +++ b/src/Orchard.Tests/Environment/Extensions/ExtensionFoldersTests.cs @@ -55,7 +55,7 @@ namespace Orchard.Tests.Environment.Extensions { [Test] public void NamesFromFoldersWithModuleTxtShouldBeListed() { IExtensionFolders folders = new ModuleFolders(new[] { _tempFolderName }, new StubCacheManager(), new StubWebSiteFolder()); - var names = folders.AvailableExtensions().Select(d => d.Name); + var names = folders.AvailableExtensions().Select(d => d.Id); Assert.That(names.Count(), Is.EqualTo(2)); Assert.That(names, Has.Some.EqualTo("Sample1")); Assert.That(names, Has.Some.EqualTo("Sample3")); @@ -64,8 +64,8 @@ namespace Orchard.Tests.Environment.Extensions { [Test] public void ModuleTxtShouldBeParsedAndReturnedAsYamlDocument() { IExtensionFolders folders = new ModuleFolders(new[] { _tempFolderName }, new StubCacheManager(), new StubWebSiteFolder()); - var sample1 = folders.AvailableExtensions().Single(d => d.Name == "Sample1"); - Assert.That(sample1.Name, Is.Not.Empty); + var sample1 = folders.AvailableExtensions().Single(d => d.Id == "Sample1"); + Assert.That(sample1.Id, Is.Not.Empty); Assert.That(sample1.Author, Is.EqualTo("Bertrand Le Roy")); } } diff --git a/src/Orchard.Tests/Environment/Extensions/ExtensionLoaderCoordinatorTests.cs b/src/Orchard.Tests/Environment/Extensions/ExtensionLoaderCoordinatorTests.cs index e7e774c1a..bb1be66b8 100644 --- a/src/Orchard.Tests/Environment/Extensions/ExtensionLoaderCoordinatorTests.cs +++ b/src/Orchard.Tests/Environment/Extensions/ExtensionLoaderCoordinatorTests.cs @@ -129,7 +129,7 @@ namespace Orchard.Tests.Environment.Extensions { var available = _manager.AvailableExtensions(); Assert.That(available.Count(), Is.EqualTo(4)); - Assert.That(available, Has.Some.Property("Name").EqualTo("foo")); + Assert.That(available, Has.Some.Property("Id").EqualTo("foo")); } [Test] @@ -141,8 +141,8 @@ Version: 2.x "); var descriptor = _manager.AvailableExtensions().Single(); - Assert.That(descriptor.Name, Is.EqualTo("Sample")); - Assert.That(descriptor.DisplayName, Is.EqualTo("Sample Extension")); + Assert.That(descriptor.Id, Is.EqualTo("Sample")); + Assert.That(descriptor.Name, Is.EqualTo("Sample Extension")); Assert.That(descriptor.Version, Is.EqualTo("2.x")); } @@ -159,12 +159,12 @@ Features: "); var descriptor = _manager.AvailableExtensions().Single(); - Assert.That(descriptor.Name, Is.EqualTo("SuperWiki")); + Assert.That(descriptor.Id, Is.EqualTo("SuperWiki")); Assert.That(descriptor.Version, Is.EqualTo("1.0.3")); Assert.That(descriptor.OrchardVersion, Is.EqualTo("1")); Assert.That(descriptor.Features.Count(), Is.EqualTo(1)); - Assert.That(descriptor.Features.First().Name, Is.EqualTo("SuperWiki")); - Assert.That(descriptor.Features.First().Extension.Name, Is.EqualTo("SuperWiki")); + Assert.That(descriptor.Features.First().Id, Is.EqualTo("SuperWiki")); + Assert.That(descriptor.Features.First().Extension.Id, Is.EqualTo("SuperWiki")); Assert.That(descriptor.Features.First().Description, Is.EqualTo("My super wiki module for Orchard.")); } @@ -197,15 +197,15 @@ Features: "); var descriptor = _manager.AvailableExtensions().Single(); - Assert.That(descriptor.Name, Is.EqualTo("MyCompany.AnotherWiki")); - Assert.That(descriptor.DisplayName, Is.EqualTo("AnotherWiki")); + Assert.That(descriptor.Id, Is.EqualTo("MyCompany.AnotherWiki")); + Assert.That(descriptor.Name, Is.EqualTo("AnotherWiki")); Assert.That(descriptor.Author, Is.EqualTo("Coder Notaprogrammer")); Assert.That(descriptor.WebSite, Is.EqualTo("http://anotherwiki.codeplex.com")); Assert.That(descriptor.Version, Is.EqualTo("1.2.3")); Assert.That(descriptor.OrchardVersion, Is.EqualTo("1")); Assert.That(descriptor.Features.Count(), Is.EqualTo(5)); foreach (var featureDescriptor in descriptor.Features) { - switch (featureDescriptor.Name) { + switch (featureDescriptor.Id) { case "AnotherWiki": Assert.That(featureDescriptor.Extension, Is.SameAs(descriptor)); Assert.That(featureDescriptor.Description, Is.EqualTo("My super wiki module for Orchard.")); @@ -306,7 +306,7 @@ Features: [Test] public void ExtensionManagerShouldThrowIfFeatureDoesNotExist() { - var featureDescriptor = new FeatureDescriptor { Name = "NoSuchFeature" }; + var featureDescriptor = new FeatureDescriptor { Id = "NoSuchFeature" }; Assert.Throws(() => _manager.LoadFeatures(new[] { featureDescriptor })); } @@ -329,7 +329,7 @@ Features: IExtensionManager extensionManager = new ExtensionManager(new[] { extensionFolder }, new[] { extensionLoader }); var testFeature = extensionManager.AvailableExtensions() .SelectMany(x => x.Features) - .Single(x => x.Name == "TestFeature"); + .Single(x => x.Id == "TestFeature"); foreach (var feature in extensionManager.LoadFeatures(new[] { testFeature })) { foreach (var type in feature.ExportedTypes) { @@ -359,7 +359,7 @@ Features: IExtensionManager extensionManager = new ExtensionManager(new[] { extensionFolder }, new[] { extensionLoader }); var testFeature = extensionManager.AvailableExtensions() .SelectMany(x => x.Features) - .Single(x => x.Name == "TestFeature"); + .Single(x => x.Id == "TestFeature"); foreach (var feature in extensionManager.LoadFeatures(new[] { testFeature })) { foreach (var type in feature.ExportedTypes) { @@ -387,7 +387,7 @@ Features: IExtensionManager extensionManager = new ExtensionManager(new[] { extensionFolder }, new[] { extensionLoader }); var testModule = extensionManager.AvailableExtensions() .SelectMany(x => x.Features) - .Single(x => x.Name == "TestModule"); + .Single(x => x.Id == "TestModule"); foreach (var feature in extensionManager.LoadFeatures(new[] { testModule })) { foreach (var type in feature.ExportedTypes) { @@ -409,10 +409,10 @@ OrchardVersion: 1 "); IExtensionManager extensionManager = new ExtensionManager(new[] { extensionFolder }, new[] { extensionLoader }); - var minimalisticModule = extensionManager.AvailableExtensions().Single(x => x.Name == "Minimalistic"); + var minimalisticModule = extensionManager.AvailableExtensions().Single(x => x.Id == "Minimalistic"); Assert.That(minimalisticModule.Features.Count(), Is.EqualTo(1)); - Assert.That(minimalisticModule.Features.Single().Name, Is.EqualTo("Minimalistic")); + Assert.That(minimalisticModule.Features.Single().Id, Is.EqualTo("Minimalistic")); } @@ -428,10 +428,10 @@ OrchardVersion: 1 "); IExtensionManager extensionManager = new ExtensionManager(new[] { extensionFolder }, new[] { extensionLoader }); - var minimalisticModule = extensionManager.AvailableExtensions().Single(x => x.Name == "Minimalistic"); + var minimalisticModule = extensionManager.AvailableExtensions().Single(x => x.Id == "Minimalistic"); Assert.That(minimalisticModule.Features.Count(), Is.EqualTo(1)); - Assert.That(minimalisticModule.Features.Single().Name, Is.EqualTo("Minimalistic")); + Assert.That(minimalisticModule.Features.Single().Id, Is.EqualTo("Minimalistic")); } } } \ No newline at end of file diff --git a/src/Orchard.Tests/Environment/Extensions/ExtensionManagerTests.cs b/src/Orchard.Tests/Environment/Extensions/ExtensionManagerTests.cs index 0bd04045b..113918ced 100644 --- a/src/Orchard.Tests/Environment/Extensions/ExtensionManagerTests.cs +++ b/src/Orchard.Tests/Environment/Extensions/ExtensionManagerTests.cs @@ -132,7 +132,7 @@ namespace Orchard.Tests.Environment.Extensions { var available = _manager.AvailableExtensions(); Assert.That(available.Count(), Is.EqualTo(4)); - Assert.That(available, Has.Some.Property("Name").EqualTo("foo")); + Assert.That(available, Has.Some.Property("Id").EqualTo("foo")); } [Test] @@ -144,8 +144,8 @@ Version: 2.x "); var descriptor = _manager.AvailableExtensions().Single(); - Assert.That(descriptor.Name, Is.EqualTo("Sample")); - Assert.That(descriptor.DisplayName, Is.EqualTo("Sample Extension")); + Assert.That(descriptor.Id, Is.EqualTo("Sample")); + Assert.That(descriptor.Name, Is.EqualTo("Sample Extension")); Assert.That(descriptor.Version, Is.EqualTo("2.x")); } @@ -162,12 +162,12 @@ Features: "); var descriptor = _manager.AvailableExtensions().Single(); - Assert.That(descriptor.Name, Is.EqualTo("SuperWiki")); + Assert.That(descriptor.Id, Is.EqualTo("SuperWiki")); Assert.That(descriptor.Version, Is.EqualTo("1.0.3")); Assert.That(descriptor.OrchardVersion, Is.EqualTo("1")); Assert.That(descriptor.Features.Count(), Is.EqualTo(1)); - Assert.That(descriptor.Features.First().Name, Is.EqualTo("SuperWiki")); - Assert.That(descriptor.Features.First().Extension.Name, Is.EqualTo("SuperWiki")); + Assert.That(descriptor.Features.First().Id, Is.EqualTo("SuperWiki")); + Assert.That(descriptor.Features.First().Extension.Id, Is.EqualTo("SuperWiki")); Assert.That(descriptor.Features.First().Description, Is.EqualTo("My super wiki module for Orchard.")); } @@ -200,15 +200,15 @@ Features: "); var descriptor = _manager.AvailableExtensions().Single(); - Assert.That(descriptor.Name, Is.EqualTo("MyCompany.AnotherWiki")); - Assert.That(descriptor.DisplayName, Is.EqualTo("AnotherWiki")); + Assert.That(descriptor.Id, Is.EqualTo("MyCompany.AnotherWiki")); + Assert.That(descriptor.Name, Is.EqualTo("AnotherWiki")); Assert.That(descriptor.Author, Is.EqualTo("Coder Notaprogrammer")); Assert.That(descriptor.WebSite, Is.EqualTo("http://anotherwiki.codeplex.com")); Assert.That(descriptor.Version, Is.EqualTo("1.2.3")); Assert.That(descriptor.OrchardVersion, Is.EqualTo("1")); Assert.That(descriptor.Features.Count(), Is.EqualTo(5)); foreach (var featureDescriptor in descriptor.Features) { - switch (featureDescriptor.Name) { + switch (featureDescriptor.Id) { case "AnotherWiki": Assert.That(featureDescriptor.Extension, Is.SameAs(descriptor)); Assert.That(featureDescriptor.Description, Is.EqualTo("My super wiki module for Orchard.")); @@ -309,7 +309,7 @@ Features: [Test] public void ExtensionManagerShouldThrowIfFeatureDoesNotExist() { - var featureDescriptor = new FeatureDescriptor { Name = "NoSuchFeature" }; + var featureDescriptor = new FeatureDescriptor { Id = "NoSuchFeature" }; Assert.Throws(() => _manager.LoadFeatures(new[] { featureDescriptor })); } @@ -332,7 +332,7 @@ Features: IExtensionManager extensionManager = new ExtensionManager(new[] { extensionFolder }, new[] { extensionLoader }); var testFeature = extensionManager.AvailableExtensions() .SelectMany(x => x.Features) - .Single(x => x.Name == "TestFeature"); + .Single(x => x.Id == "TestFeature"); foreach (var feature in extensionManager.LoadFeatures(new[] { testFeature })) { foreach (var type in feature.ExportedTypes) { @@ -362,7 +362,7 @@ Features: IExtensionManager extensionManager = new ExtensionManager(new[] { extensionFolder }, new[] { extensionLoader }); var testFeature = extensionManager.AvailableExtensions() .SelectMany(x => x.Features) - .Single(x => x.Name == "TestFeature"); + .Single(x => x.Id == "TestFeature"); foreach (var feature in extensionManager.LoadFeatures(new[] { testFeature })) { foreach (var type in feature.ExportedTypes) { @@ -390,7 +390,7 @@ Features: IExtensionManager extensionManager = new ExtensionManager(new[] { extensionFolder }, new[] { extensionLoader }); var testModule = extensionManager.AvailableExtensions() .SelectMany(x => x.Features) - .Single(x => x.Name == "TestModule"); + .Single(x => x.Id == "TestModule"); foreach (var feature in extensionManager.LoadFeatures(new[] { testModule })) { foreach (var type in feature.ExportedTypes) { @@ -412,10 +412,10 @@ OrchardVersion: 1 "); IExtensionManager extensionManager = new ExtensionManager(new[] { extensionFolder }, new[] { extensionLoader }); - var minimalisticModule = extensionManager.AvailableExtensions().Single(x => x.Name == "Minimalistic"); + var minimalisticModule = extensionManager.AvailableExtensions().Single(x => x.Id == "Minimalistic"); Assert.That(minimalisticModule.Features.Count(), Is.EqualTo(1)); - Assert.That(minimalisticModule.Features.Single().Name, Is.EqualTo("Minimalistic")); + Assert.That(minimalisticModule.Features.Single().Id, Is.EqualTo("Minimalistic")); } @@ -449,7 +449,7 @@ Features: IExtensionManager extensionManager = new ExtensionManager(new[] { extensionFolder }, new[] { extensionLoader }); var features = extensionManager.AvailableFeatures(); - Assert.That(features.Aggregate("<", (a,b)=>a+b.Name+"<"), Is.EqualTo("a+b.Id+"<"), Is.EqualTo(" a + b.Name + "<"), Is.EqualTo(" a + b.Id + "<"), Is.EqualTo("()); blueprint.Dependencies.Single().Feature = - new Feature { Descriptor = new FeatureDescriptor { Name = "Hello" } }; + new Feature { Descriptor = new FeatureDescriptor { Id = "Hello" } }; var factory = _container.Resolve(); var shellContainer = factory.CreateContainer(settings, blueprint); @@ -180,7 +180,7 @@ namespace Orchard.Tests.Environment.ShellBuilders { var testDependency2 = (TestDependency2)testDependency; Assert.That(testDependency2.Feature.Descriptor, Is.Not.Null); - Assert.That(testDependency2.Feature.Descriptor.Name, Is.EqualTo("Hello")); + Assert.That(testDependency2.Feature.Descriptor.Id, Is.EqualTo("Hello")); } public class TestDependency2 : ITestDependency { diff --git a/src/Orchard.Tests/Environment/Utility/Build.cs b/src/Orchard.Tests/Environment/Utility/Build.cs index 9c1394852..baeb8144d 100644 --- a/src/Orchard.Tests/Environment/Utility/Build.cs +++ b/src/Orchard.Tests/Environment/Utility/Build.cs @@ -29,8 +29,8 @@ namespace Orchard.Tests.Environment.Utility { public static ExtensionDescriptor ExtensionDescriptor(string name, string displayName) { var descriptor = new ExtensionDescriptor { - Name = name, - DisplayName = displayName, + Id = name, + Name = displayName, Features = Enumerable.Empty(), }; return descriptor; @@ -42,7 +42,7 @@ namespace Orchard.Tests.Environment.Utility { public static ExtensionDescriptor WithFeatures(this ExtensionDescriptor descriptor, params string[] names) { descriptor.Features = descriptor.Features.Concat( - names.Select(name => new FeatureDescriptor { Extension=descriptor , Name = name, })); + names.Select(name => new FeatureDescriptor { Extension=descriptor , Id = name, })); return descriptor; } diff --git a/src/Orchard.Tests/Mvc/OrchardControllerFactoryTests.cs b/src/Orchard.Tests/Mvc/OrchardControllerFactoryTests.cs index d95278428..6b6ee4950 100644 --- a/src/Orchard.Tests/Mvc/OrchardControllerFactoryTests.cs +++ b/src/Orchard.Tests/Mvc/OrchardControllerFactoryTests.cs @@ -42,7 +42,7 @@ namespace Orchard.Tests.Mvc { var workContext = new DefaultDisplayManagerTests.TestWorkContext { - CurrentTheme = new ExtensionDescriptor { Name = "Hello" }, + CurrentTheme = new ExtensionDescriptor { Id = "Hello" }, ContainerProvider = _containerProvider }; _workContextAccessor = new DefaultDisplayManagerTests.TestWorkContextAccessor(workContext); diff --git a/src/Orchard.Tests/Mvc/Routes/StandardExtensionRouteProviderTests.cs b/src/Orchard.Tests/Mvc/Routes/StandardExtensionRouteProviderTests.cs index ea436e6ae..3d84a312d 100644 --- a/src/Orchard.Tests/Mvc/Routes/StandardExtensionRouteProviderTests.cs +++ b/src/Orchard.Tests/Mvc/Routes/StandardExtensionRouteProviderTests.cs @@ -19,7 +19,7 @@ namespace Orchard.Tests.Mvc.Routes { Feature =new Feature { Descriptor=new FeatureDescriptor { Extension=new ExtensionDescriptor { - DisplayName="Foo" + Name="Foo" } } } @@ -29,7 +29,7 @@ namespace Orchard.Tests.Mvc.Routes { Feature =new Feature { Descriptor=new FeatureDescriptor { Extension=new ExtensionDescriptor { - DisplayName="Bar" + Name="Bar" } } } diff --git a/src/Orchard.Web/Modules/Orchard.CodeGeneration/Commands/CodeGenerationCommands.cs b/src/Orchard.Web/Modules/Orchard.CodeGeneration/Commands/CodeGenerationCommands.cs index 74ca7d5f1..6fa70926e 100644 --- a/src/Orchard.Web/Modules/Orchard.CodeGeneration/Commands/CodeGenerationCommands.cs +++ b/src/Orchard.Web/Modules/Orchard.CodeGeneration/Commands/CodeGenerationCommands.cs @@ -53,24 +53,24 @@ namespace Orchard.CodeGeneration.Commands { Context.Output.WriteLine(T("Creating Data Migration for {0}", featureName)); ExtensionDescriptor extensionDescriptor = _extensionManager.AvailableExtensions().FirstOrDefault(extension => extension.ExtensionType == "Module" && - extension.Features.Any(feature => String.Equals(feature.Name, featureName, StringComparison.OrdinalIgnoreCase))); + extension.Features.Any(feature => String.Equals(feature.Id, featureName, StringComparison.OrdinalIgnoreCase))); if (extensionDescriptor == null) { Context.Output.WriteLine(T("Creating data migration failed: target Feature {0} could not be found.", featureName)); return false; } - string dataMigrationFolderPath = HostingEnvironment.MapPath("~/Modules/" + extensionDescriptor.Name + "/"); + string dataMigrationFolderPath = HostingEnvironment.MapPath("~/Modules/" + extensionDescriptor.Id + "/"); string dataMigrationFilePath = dataMigrationFolderPath + "Migrations.cs"; string templatesPath = HostingEnvironment.MapPath("~/Modules/Orchard." + ModuleName + "/CodeGenerationTemplates/"); - string moduleCsProjPath = HostingEnvironment.MapPath(string.Format("~/Modules/{0}/{0}.csproj", extensionDescriptor.Name)); + string moduleCsProjPath = HostingEnvironment.MapPath(string.Format("~/Modules/{0}/{0}.csproj", extensionDescriptor.Id)); if (!Directory.Exists(dataMigrationFolderPath)) { Directory.CreateDirectory(dataMigrationFolderPath); } if (File.Exists(dataMigrationFilePath)) { - Context.Output.WriteLine(T("Data migration already exists in target Module {0}.", extensionDescriptor.Name)); + Context.Output.WriteLine(T("Data migration already exists in target Module {0}.", extensionDescriptor.Id)); return false; } @@ -104,7 +104,7 @@ namespace Orchard.CodeGeneration.Commands { File.WriteAllText(moduleCsProjPath, projectFileText); TouchSolution(Context.Output); - Context.Output.WriteLine(T("Data migration created successfully in Module {0}", extensionDescriptor.Name)); + Context.Output.WriteLine(T("Data migration created successfully in Module {0}", extensionDescriptor.Id)); return true; } @@ -115,7 +115,7 @@ namespace Orchard.CodeGeneration.Commands { public bool CreateModule(string moduleName) { Context.Output.WriteLine(T("Creating Module {0}", moduleName)); - if ( _extensionManager.AvailableExtensions().Any(extension => String.Equals(moduleName, extension.DisplayName, StringComparison.OrdinalIgnoreCase)) ) { + if ( _extensionManager.AvailableExtensions().Any(extension => String.Equals(moduleName, extension.Name, StringComparison.OrdinalIgnoreCase)) ) { Context.Output.WriteLine(T("Creating Module {0} failed: a module of the same name already exists", moduleName)); return false; } @@ -131,14 +131,14 @@ namespace Orchard.CodeGeneration.Commands { [OrchardSwitches("IncludeInSolution,BasedOn,CreateProject")] public void CreateTheme(string themeName) { Context.Output.WriteLine(T("Creating Theme {0}", themeName)); - if (_extensionManager.AvailableExtensions().Any(extension => String.Equals(themeName, extension.Name, StringComparison.OrdinalIgnoreCase))) { + if (_extensionManager.AvailableExtensions().Any(extension => String.Equals(themeName, extension.Id, StringComparison.OrdinalIgnoreCase))) { Context.Output.WriteLine(T("Creating Theme {0} failed: an extention of the same name already exists", themeName)); } else { if (!string.IsNullOrEmpty(BasedOn)) { if (!_extensionManager.AvailableExtensions().Any(extension => string.Equals(extension.ExtensionType, "Theme", StringComparison.OrdinalIgnoreCase) && - string.Equals(BasedOn, extension.Name, StringComparison.OrdinalIgnoreCase))) { + string.Equals(BasedOn, extension.Id, StringComparison.OrdinalIgnoreCase))) { Context.Output.WriteLine(T("Creating Theme {0} failed: base theme named {1} was not found.", themeName, BasedOn)); return; } @@ -154,16 +154,16 @@ namespace Orchard.CodeGeneration.Commands { Context.Output.WriteLine(T("Creating Controller {0} in Module {1}", controllerName, moduleName)); ExtensionDescriptor extensionDescriptor = _extensionManager.AvailableExtensions().FirstOrDefault(extension => extension.ExtensionType == "Module" && - string.Equals(moduleName, extension.DisplayName, StringComparison.OrdinalIgnoreCase)); + string.Equals(moduleName, extension.Name, StringComparison.OrdinalIgnoreCase)); if (extensionDescriptor == null) { Context.Output.WriteLine(T("Creating Controller {0} failed: target Module {1} could not be found.", controllerName, moduleName)); return; } - string moduleControllersPath = HostingEnvironment.MapPath("~/Modules/" + extensionDescriptor.Name + "/Controllers/"); + string moduleControllersPath = HostingEnvironment.MapPath("~/Modules/" + extensionDescriptor.Id + "/Controllers/"); string controllerPath = moduleControllersPath + controllerName + ".cs"; - string moduleCsProjPath = HostingEnvironment.MapPath(string.Format("~/Modules/{0}/{0}.csproj", extensionDescriptor.Name)); + string moduleCsProjPath = HostingEnvironment.MapPath(string.Format("~/Modules/{0}/{0}.csproj", extensionDescriptor.Id)); string templatesPath = HostingEnvironment.MapPath("~/Modules/Orchard." + ModuleName + "/CodeGenerationTemplates/"); if (!Directory.Exists(moduleControllersPath)) { diff --git a/src/Orchard.Web/Modules/Orchard.Experimental/Views/DumpShapeTable.cshtml b/src/Orchard.Web/Modules/Orchard.Experimental/Views/DumpShapeTable.cshtml index 62843e179..7aa4c1efc 100644 --- a/src/Orchard.Web/Modules/Orchard.Experimental/Views/DumpShapeTable.cshtml +++ b/src/Orchard.Web/Modules/Orchard.Experimental/Views/DumpShapeTable.cshtml @@ -3,7 +3,7 @@ @Display(Model.Metadata.ChildContent) @{ var workContext = ViewContext.GetWorkContext(); - var shapeTable = workContext.Resolve().GetShapeTable(workContext.CurrentTheme.Name); + var shapeTable = workContext.Resolve().GetShapeTable(workContext.CurrentTheme.Id);