lsm/Orchard
1
0
Fork 0
mirror of https://github.com/OrchardCMS/Orchard.git synced 2025-04-05 21:01:35 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Catching exceptions before they are thrown when adding new shapes

Browse Source 
--HG--
branch : dev
This commit is contained in:
Sebastien Ros 2010-11-16 17:14:36 -08:00
parent 133b1e9b92
commit 545f2861ef
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/Orchard/DisplayManagement/Shapes/Shape.cs
View File

@ -1,5 +1,7 @@
using System.Collections; using System;
using System.Collections;
using System.Collections.Generic; using System.Collections.Generic;
using System.Web.Mvc;
namespace Orchard.DisplayManagement.Shapes { namespace Orchard.DisplayManagement.Shapes {
public class Shape : IShape, IEnumerable { public class Shape : IShape, IEnumerable {
@ -18,11 +20,19 @@ namespace Orchard.DisplayManagement.Shapes {
public virtual Shape Add(object item, string position = DefaultPosition) { public virtual Shape Add(object item, string position = DefaultPosition) {
try { try {
((dynamic)item).Metadata.Position = position; // todo: (sebros) this is a temporary implementation to prevent common known scenarios throwing exceptions. The final solution would need to filter based on the fact that it is a Shape instance
if ( item is MvcHtmlString ||
item is String ) {
// need to implement positioned wrapper for non-shape objects
}
else {
((dynamic) item).Metadata.Position = position;
}
} }
catch { catch {
// need to implemented positioned wrapper for non-shape objects // need to implement positioned wrapper for non-shape objects
} }
_items.Add(item); // not messing with position at the moment _items.Add(item); // not messing with position at the moment
return this; return this;
} }